Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2411453003: Fix --verify-on-transition for OSR and concurrent sweep. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix --verify-on-transition for OSR and concurrent sweep. Wait for concurrent sweep tasks before verifying points, as building the allocation set expects unmarked objects. Make assertion okay with a missing stack map at entry, which transiently exists for OSR, as the frame looks the same as unoptimized code here. Fixes #13608 Fixes #23683 Reproduces issue #26927 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/bb85b32d515c0035a38e1145b5dd8e0acd83d71c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M runtime/vm/lockers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/native_entry.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-10 21:55:08 UTC) #2
Florian Schneider
Lgtm.
4 years, 2 months ago (2016-10-11 17:08:39 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-11 22:03:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb85b32d515c0035a38e1145b5dd8e0acd83d71c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698