Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Side by Side Diff: runtime/vm/native_arguments.h

Issue 2411453003: Fix --verify-on-transition for OSR and concurrent sweep. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/lockers.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_NATIVE_ARGUMENTS_H_ 5 #ifndef VM_NATIVE_ARGUMENTS_H_
6 #define VM_NATIVE_ARGUMENTS_H_ 6 #define VM_NATIVE_ARGUMENTS_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "platform/memory_sanitizer.h" 9 #include "platform/memory_sanitizer.h"
10 #include "vm/globals.h" 10 #include "vm/globals.h"
(...skipping 26 matching lines...) Expand all
37 #define CHECK_STACK_ALIGNMENT { } 37 #define CHECK_STACK_ALIGNMENT { }
38 #else 38 #else
39 #define CHECK_STACK_ALIGNMENT { \ 39 #define CHECK_STACK_ALIGNMENT { \
40 uword (*func)() = reinterpret_cast<uword (*)()>( \ 40 uword (*func)() = reinterpret_cast<uword (*)()>( \
41 StubCode::GetStackPointer_entry()->EntryPoint()); \ 41 StubCode::GetStackPointer_entry()->EntryPoint()); \
42 uword current_sp = func(); \ 42 uword current_sp = func(); \
43 ASSERT(Utils::IsAligned(current_sp, OS::ActivationFrameAlignment())); \ 43 ASSERT(Utils::IsAligned(current_sp, OS::ActivationFrameAlignment())); \
44 } 44 }
45 #endif 45 #endif
46 46
47 void VerifyOnTransition();
48
47 #define VERIFY_ON_TRANSITION \ 49 #define VERIFY_ON_TRANSITION \
48 if (FLAG_verify_on_transition) { \ 50 if (FLAG_verify_on_transition) { \
49 VerifyPointersVisitor::VerifyPointers(); \ 51 VerifyOnTransition(); \
50 Isolate::Current()->heap()->Verify(); \
51 } 52 }
52 #define DEOPTIMIZE_ALOT \ 53 #define DEOPTIMIZE_ALOT \
53 if (FLAG_deoptimize_alot) { \ 54 if (FLAG_deoptimize_alot) { \
54 DeoptimizeFunctionsOnStack(); \ 55 DeoptimizeFunctionsOnStack(); \
55 } 56 }
56 57
57 #else 58 #else
58 59
59 #define CHECK_STACK_ALIGNMENT { } 60 #define CHECK_STACK_ALIGNMENT { }
60 #define VERIFY_ON_TRANSITION { } 61 #define VERIFY_ON_TRANSITION { }
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 256
256 Thread* thread_; // Current thread pointer. 257 Thread* thread_; // Current thread pointer.
257 intptr_t argc_tag_; // Encodes argument count and invoked native call type. 258 intptr_t argc_tag_; // Encodes argument count and invoked native call type.
258 RawObject** argv_; // Pointer to an array of arguments to runtime call. 259 RawObject** argv_; // Pointer to an array of arguments to runtime call.
259 RawObject** retval_; // Pointer to the return value area. 260 RawObject** retval_; // Pointer to the return value area.
260 }; 261 };
261 262
262 } // namespace dart 263 } // namespace dart
263 264
264 #endif // VM_NATIVE_ARGUMENTS_H_ 265 #endif // VM_NATIVE_ARGUMENTS_H_
OLDNEW
« no previous file with comments | « runtime/vm/lockers.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698