Move ENABLE_PEPPER_CDMS to a buildflag header.

Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)

Committed: https://crrev.com/e23a62a0c4b56618da615698717ed53983854f8d
Cr-Commit-Position: refs/heads/master@{#424477}

[brettw, 2016-10-10 20:47:30]

Missing .h

[brettw, 2016-10-10 20:47:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-10-10 20:47:51]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes teh global build flag and #define and converts to a buildflag header in
third_party/widevine/cdm.

BUG=
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes teh global build flag and #define and converts to a buildflag header in
third_party/widevine/cdm.
==========

[commit-bot: I haz the power, 2016-10-10 20:47:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-10-10 20:48:05]

brettw@chromium.org changed reviewers:
+ ddorwin@chromium.org

[brettw, 2016-10-10 20:48:20]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes teh global build flag and #define and converts to a buildflag header in
third_party/widevine/cdm.
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
third_party/widevine/cdm.
==========

[ddorwin, 2016-10-10 20:50:53]

ddorwin@chromium.org changed reviewers:
+ jrummell@chromium.org

[ddorwin, 2016-10-10 20:50:53]

Thanks!
=> jrummell for review

[commit-bot: I haz the power, 2016-10-10 20:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:52:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2016-10-10 20:54:25]

fix

[brettw, 2016-10-10 20:54:25]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:54:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:11:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jrummell, 2016-10-10 22:45:58]

Couple of nits plus a question on why the flag is in third_party/widevine/cdm
below.

https://codereview.chromium.org/2411433002/diff/40001/chrome/browser/media/en...
File chrome/browser/media/encrypted_media_supported_types_browsertest.cc
(right):

https://codereview.chromium.org/2411433002/diff/40001/chrome/browser/media/en...
chrome/browser/media/encrypted_media_supported_types_browsertest.cc:713: #if
!BUILDFLAG(WIDEVINE_CDM_AVAILABLE)
Did you mean to change this? Line 93 still has #if
defined(WIDEVINE_CDM_AVAILABLE)

https://codereview.chromium.org/2411433002/diff/40001/third_party/widevine/cd...
File third_party/widevine/cdm/widevine.gni (right):

https://codereview.chromium.org/2411433002/diff/40001/third_party/widevine/cd...
third_party/widevine/cdm/widevine.gni:17: enable_plugins && (is_linux || is_mac
|| is_win) && !is_chromecast
Why did you put the flag in third_party/widevine/cdm? For testing we also build
ExternalClearKey (see media/cdm/ppapi/BUILD.gn). I think media/cdm/ppapi/ is a
better place to put the flag, since that is where all the Chromium code to
handle pepper plugins is located. (Plus when we complete the switch to mojo,
widevine will remain but the code in media/cdm/ppapi/ should disappear).

https://codereview.chromium.org/2411433002/diff/40001/tools/gn/docs/cookbook.md
File tools/gn/docs/cookbook.md (right):

https://codereview.chromium.org/2411433002/diff/40001/tools/gn/docs/cookbook....
tools/gn/docs/cookbook.md:256: | `enable_pepper_cdms` (0/1)              |
`enable_pepper_cdms` (true/false)              |
`//third_party/widevine/cdm/widevin.gni` |
Should this be widevine.gni (missing last e)?

[brettw, 2016-10-10 22:55:27]

CrOS fix

[brettw, 2016-10-10 22:55:28]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:55:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-10-10 23:43:17]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
third_party/widevine/cdm.
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.
==========

[brettw, 2016-10-10 23:43:22]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-10 23:43:23]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-10-10 23:43:25]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-10-10 23:43:42]

New snap up.

https://codereview.chromium.org/2411433002/diff/40001/chrome/browser/media/en...
File chrome/browser/media/encrypted_media_supported_types_browsertest.cc
(right):

https://codereview.chromium.org/2411433002/diff/40001/chrome/browser/media/en...
chrome/browser/media/encrypted_media_supported_types_browsertest.cc:713: #if
!BUILDFLAG(WIDEVINE_CDM_AVAILABLE)
Fixed, trybots also noticed this :)

https://codereview.chromium.org/2411433002/diff/40001/third_party/widevine/cd...
File third_party/widevine/cdm/widevine.gni (right):

https://codereview.chromium.org/2411433002/diff/40001/third_party/widevine/cd...
third_party/widevine/cdm/widevine.gni:17: enable_plugins && (is_linux || is_mac
|| is_win) && !is_chromecast
Good idea, done.

[commit-bot: I haz the power, 2016-10-10 23:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2016-10-10 23:55:52]

Thanks for doing this. LGTM.

[commit-bot: I haz the power, 2016-10-11 01:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 01:51:09]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-11 03:15:57]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-11 03:16:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 03:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 03:26:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-10-11 05:02:37]

David: need your owners stamp for widevine.

[ddorwin, 2016-10-11 05:09:18]

widevine lgtm

[ddorwin, 2016-10-11 05:30:40]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-10-11 05:30:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 05:40:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 05:40:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-10-11 17:35:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:36:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-10-11 17:36:59]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)
==========

[brettw, 2016-10-11 17:36:59]

brettw@chromium.org changed reviewers:
+ jschuh@chromium.org

[brettw, 2016-10-11 17:37:15]

TBR=jschuh (render_messages.h)

[commit-bot: I haz the power, 2016-10-11 17:44:39]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)
==========

[commit-bot: I haz the power, 2016-10-11 17:44:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-11 17:46:16]

Description was changed from

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)
==========

to

==========
Move ENABLE_PEPPER_CDMS to a buildflag header.

Removes the global build flag and #define and converts to a buildflag header in
ppapi/features.

A new target "//third_party/widevine/cdm:headers" was added since
widevine_cdm_version.h was unreferenced in the build. Given that this file now
requires //ppapi/features we really need "gn check" to work on it. I made the
existing users of ":version_h" reference this new target which encompasses the
public headers of the widevine CDM.

TBR=jschuh (render_messages.h)

Committed: https://crrev.com/e23a62a0c4b56618da615698717ed53983854f8d
Cr-Commit-Position: refs/heads/master@{#424477}
==========

[commit-bot: I haz the power, 2016-10-11 17:46:18]

Patchset 5 (id:??) landed as
https://crrev.com/e23a62a0c4b56618da615698717ed53983854f8d
Cr-Commit-Position: refs/heads/master@{#424477}

[alph, 2016-10-11 19:12:26]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2412493003/ by alph@chromium.org.

The reason for reverting is: Broke build
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/b....