third_party/widevine/cdm/widevine.gni - Issue 2411433002: Move ENABLE_PEPPER_CDMS to a buildflag header.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/widevine/cdm/widevine.gni

Issue 2411433002: Move ENABLE_PEPPER_CDMS to a buildflag header. (Closed)

Patch Set: fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 import("//build/config/features.gni")

	6

5 declare_args() {	7 declare_args() {

6 # Allow widevinecdmadapter to be built in Chromium.	8 # Allow widevinecdmadapter to be built in Chromium.

7 enable_widevine = false	9 enable_widevine = false

8 }	10 }

	11

	12 # Enables the use of CDMs in pepper plugins.

	13 #

	14 # This is available as a buildflag for C++ preprocessor, see

	15 # //third_party/widevine/cdm:cdm_features.

	16 enable_pepper_cdms =

	17 enable_plugins && (is_linux \|\| is_mac \|\| is_win) && !is_chromecast
	jrummell 2016/10/10 22:45:57 Why did you put the flag in third_party/widevine/c Why did you put the flag in third_party/widevine/cdm? For testing we also build ExternalClearKey (see media/cdm/ppapi/BUILD.gn). I think media/cdm/ppapi/ is a better place to put the flag, since that is where all the Chromium code to handle pepper plugins is located. (Plus when we complete the switch to mojo, widevine will remain but the code in media/cdm/ppapi/ should disappear). brettw 2016/10/10 23:43:42 Good idea, done. Good idea, done.
OLD	NEW