Chromium Code Reviews Chromium Code Reviews
Issue 2411333007:
[css-grid] Avoid storing pointers to orthogonal grid items (Closed)
| Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..671ebc367d1e91f8e127a2bcb1b331fd4b142df7 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html |
| @@ -0,0 +1,32 @@ |
| +<!DOCTYPE html> |
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel="stylesheet"> |
| +<script> |
| +if (window.testRunner) { |
| + testRunner.dumpAsText(); |
| +} |
| +</script> |
| +<script> |
|
Manuel Rego
2016/10/17 09:13:41
Nit: You don't need to close the <script> tag
and
jfernandez
2016/10/17 09:21:42
Acknowledged.
|
| +function domfuzz_crawlNode(node) { |
|
svillar
2016/10/17 08:28:19
Nit: weird function name, likely coming from the f
jfernandez
2016/10/17 09:21:42
Acknowledged.
|
| + for (var key in node) { |
| + try { |
| + var a = node[key]; |
| + node[key] = null; |
| + } catch (e) { |
|
svillar
2016/10/17 08:28:19
I guess you can remove the try-catch as you are no
jfernandez
2016/10/17 09:21:42
Acknowledged.
jfernandez
2016/10/17 12:37:37
Actually we can't remove the try-catch, since some
|
| + } |
| + } |
| +} |
| + |
| +function runTest() { |
| + document.body.offsetLeft; |
| + |
| + var element = document.getElementById("node"); |
| + domfuzz_crawlNode(element); |
| +} |
| +</script> |
| +<body onload="runTest();"> |
| +<p>This test passes if it does not crash.</p> |
| +<div class="grid verticalRL fit-content"> |
| + <div id="node" class="firstRowFirstColumn horizontalTB"></div> |
|
Manuel Rego
2016/10/17 09:13:41
Nit: I guess all those classes are needed to repro
jfernandez
2016/10/17 09:21:42
We indeed need fit-content, because we only clear
|
| +</div> |
| +</body> |
