third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html - Issue 2411333007: [css-grid] Avoid storing pointers to orthogonal grid items

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632.html

Issue 2411333007: [css-grid] Avoid storing pointers to orthogonal grid items (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/regression-test-for-issue-655632-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet">

	4 <script>

	5 if (window.testRunner) {

	6 testRunner.dumpAsText();

	7 }

	8 </script>

	9 <script>
	Manuel Rego 2016/10/17 09:13:41 Nit: You don't need to close the <script> tag and Nit: You don't need to close the <script> tag and open it again in the next line. jfernandez 2016/10/17 09:21:42 Acknowledged. Show quoted text On 2016/10/17 09:13:41, Manuel Rego wrote: > Nit: You don't need to close the <script> tag > and open it again in the next line. Acknowledged.
	10 function domfuzz_crawlNode(node) {
	svillar 2016/10/17 08:28:19 Nit: weird function name, likely coming from the f Nit: weird function name, likely coming from the fuzzer. jfernandez 2016/10/17 09:21:42 Acknowledged. Show quoted text On 2016/10/17 08:28:19, svillar wrote: > Nit: weird function name, likely coming from the fuzzer. Acknowledged.
	11 for (var key in node) {

	12 try {

	13 var a = node[key];

	14 node[key] = null;

	15 } catch (e) {
	svillar 2016/10/17 08:28:19 I guess you can remove the try-catch as you are no I guess you can remove the try-catch as you are not doing anything in case of exception jfernandez 2016/10/17 09:21:42 Acknowledged. Show quoted text On 2016/10/17 08:28:19, svillar wrote: > I guess you can remove the try-catch as you are not doing anything in case of > exception Acknowledged. jfernandez 2016/10/17 12:37:37 Actually we can't remove the try-catch, since some Show quoted text On 2016/10/17 08:28:19, svillar wrote: > I guess you can remove the try-catch as you are not doing anything in case of > exception Actually we can't remove the try-catch, since some properties don't allow null as value, so without catching the exception, the script is not completed.
	16 }

	17 }

	18 }

	19

	20 function runTest() {

	21 document.body.offsetLeft;

	22

	23 var element = document.getElementById("node");

	24 domfuzz_crawlNode(element);

	25 }

	26 </script>

	27 <body onload="runTest();">

	28 <p>This test passes if it does not crash.</p>

	29 <div class="grid verticalRL fit-content">

	30 <div id="node" class="firstRowFirstColumn horizontalTB"></div>
	Manuel Rego 2016/10/17 09:13:41 Nit: I guess all those classes are needed to repro Nit: I guess all those classes are needed to reproduced it. Maybe we don't need "fit-content" or "firstRowFirstColumn", dunno really. jfernandez 2016/10/17 09:21:42 We indeed need fit-content, because we only clear Show quoted text On 2016/10/17 09:13:41, Manuel Rego wrote: > Nit: I guess all those classes are needed to reproduced it. > Maybe we don't need "fit-content" or "firstRowFirstColumn", > dunno really. We indeed need fit-content, because we only clear the override sizes when it's necessary to recompute the grid's intrinsic size. We can remove the firstRowFirstColumn class, though.
	31 </div>

	32 </body>

OLD	NEW