Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2411333005: Remove the NOTREACHED introduced by crrev.com/2323483005. (Closed)

Created:
4 years, 2 months ago by ssid
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add another todo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/trace_event/trace_log.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
ssid
ptal, thanks
4 years, 2 months ago (2016-10-13 23:33:36 UTC) #2
Ilya Kulshin
lgtm https://codereview.chromium.org/2411333005/diff/1/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/2411333005/diff/1/base/trace_event/trace_log.cc#newcode879 base/trace_event/trace_log.cc:879: DLOG(ERROR) Add TODO here, similar to the previous ...
4 years, 2 months ago (2016-10-13 23:35:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411333005/20001
4 years, 2 months ago (2016-10-13 23:37:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 00:34:26 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 00:37:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77addc4fba2b9eb4354ba652b50e2c9cdb8475f3
Cr-Commit-Position: refs/heads/master@{#425215}

Powered by Google App Engine
This is Rietveld 408576698