Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: base/trace_event/trace_log.cc

Issue 2411333005: Remove the NOTREACHED introduced by crrev.com/2323483005. (Closed)
Patch Set: Add another todo. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_log.cc
diff --git a/base/trace_event/trace_log.cc b/base/trace_event/trace_log.cc
index a3d146ad51451be1fd15c4d1295f66eb325b383f..6b17368c6d1c320ba1d755c8e6d4c384fad4b3d9 100644
--- a/base/trace_event/trace_log.cc
+++ b/base/trace_event/trace_log.cc
@@ -746,7 +746,8 @@ void TraceLog::SetEnabled(const TraceConfig& trace_config,
InternalTraceOptions old_options = trace_options();
if (dispatching_to_observer_list_) {
- NOTREACHED()
+ // TODO(ssid): Change to NOTREACHED after fixing crbug.com/625170.
+ DLOG(ERROR)
<< "Cannot manipulate TraceLog::Enabled state from an observer.";
return;
}
@@ -875,7 +876,8 @@ void TraceLog::SetDisabledWhileLocked(uint8_t modes_to_disable) {
return;
if (dispatching_to_observer_list_) {
- NOTREACHED()
+ // TODO(ssid): Change to NOTREACHED after fixing crbug.com/625170.
+ DLOG(ERROR)
<< "Cannot manipulate TraceLog::Enabled state from an observer.";
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698