Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issue 2411263004: [wasm] API renames for wasm serialization/deserialization (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson, jbroman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] API renames for wasm serialization/deserialization This incorporates recent feedback: - simpler deserialization API by dropping the std::unique_ptr. The only purpose there was communicating to the caller that they own the buffer, and that the deserializer won't delete it. The new design communicates that through a naming choice. - renamed *UncompiledBytes to *WasmWireBytes BUG= Committed: https://crrev.com/38ac7fe6583b66d6f2bc678cb7b888281baa3363 Cr-Commit-Position: refs/heads/master@{#40238}

Patch Set 1 #

Patch Set 2 : [wasm] API renames for wasm serialization/deserialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M include/v8.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/api.cc View 4 chunks +19 lines, -14 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Mircea Trofin
4 years, 2 months ago (2016-10-12 18:02:07 UTC) #3
titzer
lgtm
4 years, 2 months ago (2016-10-12 18:53:41 UTC) #8
jbroman
non-owner lgtm
4 years, 2 months ago (2016-10-12 19:00:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411263004/20001
4 years, 2 months ago (2016-10-12 20:08:49 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 20:11:12 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 20:11:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38ac7fe6583b66d6f2bc678cb7b888281baa3363
Cr-Commit-Position: refs/heads/master@{#40238}

Powered by Google App Engine
This is Rietveld 408576698