Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: include/v8.h

Issue 2411263004: [wasm] API renames for wasm serialization/deserialization (Closed)
Patch Set: [wasm] API renames for wasm serialization/deserialization Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 1ab93b53fe1808d829c205e5681eedab5eae982a..7a1fb6c1f2f07ba53a4941ba3c8e63e695354d29 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3902,9 +3902,10 @@ class V8_EXPORT Proxy : public Object {
class V8_EXPORT WasmCompiledModule : public Object {
public:
typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
- typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> UncompiledBytes;
- // Get the uncompiled bytes that were used to compile this module.
- Local<String> GetUncompiledBytes();
+ // A buffer that is owned by the caller.
+ typedef std::pair<const uint8_t*, size_t> CallerOwnedBuffer;
+ // Get the wasm-encoded bytes that were used to compile this module.
+ Local<String> GetWasmWireBytes();
// Serialize the compiled module. The serialized data does not include the
// uncompiled bytes.
@@ -3913,15 +3914,17 @@ class V8_EXPORT WasmCompiledModule : public Object {
// TODO(mtrofin): Back-compat. Move to private once change lands in Chrome.
// The resulting wasm setup won't have its uncompiled bytes available.
static MaybeLocal<WasmCompiledModule> Deserialize(
- Isolate* isolate, const SerializedModule& serialized_data);
+ Isolate* isolate, const SerializedModule& serialized_module);
// If possible, deserialize the module, otherwise compile it from the provided
// uncompiled bytes.
static MaybeLocal<WasmCompiledModule> DeserializeOrCompile(
- Isolate* isolate, const SerializedModule& serialized_data,
- const UncompiledBytes& uncompiled_bytes);
+ Isolate* isolate, const CallerOwnedBuffer& serialized_module,
+ const CallerOwnedBuffer& wire_bytes);
V8_INLINE static WasmCompiledModule* Cast(Value* obj);
private:
+ static MaybeLocal<WasmCompiledModule> Deserialize(
+ Isolate* isolate, const CallerOwnedBuffer& serialized_module);
static MaybeLocal<WasmCompiledModule> Compile(Isolate* isolate,
const uint8_t* start,
size_t length);
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698