Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2411253002: [windows] Implements FreeSubSegment (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/vm/virtual_memory_win.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 2 months ago (2016-10-13 16:02:36 UTC) #2
siva
lgtm https://codereview.chromium.org/2411253002/diff/1/runtime/vm/virtual_memory_win.cc File runtime/vm/virtual_memory_win.cc (right): https://codereview.chromium.org/2411253002/diff/1/runtime/vm/virtual_memory_win.cc#newcode49 runtime/vm/virtual_memory_win.cc:49: FATAL("VirtualFree failed"); might be worthwhile to report the ...
4 years, 2 months ago (2016-10-13 16:11:41 UTC) #3
zra
https://codereview.chromium.org/2411253002/diff/1/runtime/vm/virtual_memory_win.cc File runtime/vm/virtual_memory_win.cc (right): https://codereview.chromium.org/2411253002/diff/1/runtime/vm/virtual_memory_win.cc#newcode49 runtime/vm/virtual_memory_win.cc:49: FATAL("VirtualFree failed"); On 2016/10/13 16:11:40, siva wrote: > might ...
4 years, 2 months ago (2016-10-13 16:56:09 UTC) #4
zra
4 years, 2 months ago (2016-10-13 16:56:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c83c381ec66eade35cb7ad3632a68edb362aa0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698