Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 2411253002: [windows] Implements FreeSubSegment (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/virtual_memory_win.cc
diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc
index 25846136a996007789204103b8fc3aba808b33ed..f50d78fb718af3930a81929281180b8a797e39db 100644
--- a/runtime/vm/virtual_memory_win.cc
+++ b/runtime/vm/virtual_memory_win.cc
@@ -39,16 +39,16 @@ VirtualMemory::~VirtualMemory() {
return;
}
if (VirtualFree(address(), 0, MEM_RELEASE) == 0) {
- FATAL("VirtualFree failed");
+ FATAL1("VirtualFree failed: Error code %d\n", GetLastError());
}
}
bool VirtualMemory::FreeSubSegment(void* address, intptr_t size) {
- // On Windows only the entire segment returned by VirtualAlloc
- // can be freed. Therefore we will have to waste these unused
- // virtual memory sub-segments.
- return false;
+ if (VirtualFree(address, size, MEM_DECOMMIT) == 0) {
+ FATAL1("VirtualFree failed: Error code %d\n", GetLastError());
+ }
+ return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698