Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 2411143003: Make WebContentsObserver::DidGetUserInteraction fire on TouchStart instead of GestureTapBegin. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc
index 6f92ab3242495984740e457b6f1021833eafe3e8..5e83a972b12d06debff46ef9c8b47ee599b8e3c0 100644
--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc
@@ -151,8 +151,8 @@ TEST_F(SiteEngagementHelperTest, ScrollEventEngagementAccumulation) {
UserInputAccumulation(blink::WebInputEvent::GestureScrollBegin);
}
-TEST_F(SiteEngagementHelperTest, GestureEngagementAccumulation) {
- UserInputAccumulation(blink::WebInputEvent::GestureTapDown);
+TEST_F(SiteEngagementHelperTest, TouchEngagementAccumulation) {
+ UserInputAccumulation(blink::WebInputEvent::TouchStart);
}
TEST_F(SiteEngagementHelperTest, MediaEngagementAccumulation) {
@@ -308,9 +308,9 @@ TEST_F(SiteEngagementHelperTest, MixedInputEngagementAccumulation) {
HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::RawKeyDown);
HandleUserInputAndRestartTracking(helper,
- blink::WebInputEvent::GestureTapDown);
+ blink::WebInputEvent::TouchStart);
HandleUserInputAndRestartTracking(helper,
- blink::WebInputEvent::GestureTapDown);
+ blink::WebInputEvent::TouchStart);
HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::RawKeyDown);
HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::MouseDown);
@@ -336,7 +336,7 @@ TEST_F(SiteEngagementHelperTest, MixedInputEngagementAccumulation) {
HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::MouseDown);
HandleMediaPlaying(helper, true);
HandleUserInputAndRestartTracking(helper,
- blink::WebInputEvent::GestureTapDown);
+ blink::WebInputEvent::TouchStart);
HandleMediaPlaying(helper, false);
EXPECT_DOUBLE_EQ(0.93, service->GetScore(url1));
@@ -368,7 +368,7 @@ TEST_F(SiteEngagementHelperTest, MixedInputEngagementAccumulation) {
EXPECT_DOUBLE_EQ(1.43, service->GetTotalEngagementPoints());
HandleUserInputAndRestartTracking(helper,
- blink::WebInputEvent::GestureTapDown);
+ blink::WebInputEvent::TouchStart);
HandleUserInputAndRestartTracking(helper, blink::WebInputEvent::RawKeyDown);
EXPECT_DOUBLE_EQ(0.93, service->GetScore(url1));
@@ -441,7 +441,7 @@ TEST_F(SiteEngagementHelperTest, CheckTimerAndCallbacks) {
EXPECT_TRUE(media_tracker_timer->IsRunning());
// Timer should start running again after input.
- HandleUserInput(helper, blink::WebInputEvent::GestureTapDown);
+ HandleUserInput(helper, blink::WebInputEvent::TouchStart);
EXPECT_TRUE(input_tracker_timer->IsRunning());
EXPECT_FALSE(IsTrackingInput(helper));
EXPECT_TRUE(media_tracker_timer->IsRunning());
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698