chrome/browser/engagement/site_engagement_helper.cc - Issue 2411143003: Make WebContentsObserver::DidGetUserInteraction fire on TouchStart instead of GestureTapBegin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 2411143003: Make WebContentsObserver::DidGetUserInteraction fire on TouchStart instead of GestureTapBegin. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index 19740d52bdd6a351ad5694ea8de3fbc9dd858ef0..634f9d1c8248bc291870c623ba911e81b57500a9 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -100,7 +100,7 @@ void SiteEngagementService::Helper::InputTracker::DidGetUserInteraction(

case blink::WebInputEvent::MouseDown:

helper()->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_MOUSE);

break;

- case blink::WebInputEvent::GestureTapDown:

+ case blink::WebInputEvent::TouchStart:

helper()->RecordUserInput(

SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE);

break;