Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 241113002: Remove some dead code from html/ (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
gmorrita, adamk, eseidel
CC:
blink-reviews, gavinp+prerender_chromium.org, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove some dead code from html/ Remove some dead code from html/. Several methods were defined but never used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171959

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 1 comment Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/MediaController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/PluginDocument.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLProgram.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 20:33:29 UTC) #1
adamk
https://codereview.chromium.org/241113002/diff/1/Source/core/html/HTMLLinkElement.h File Source/core/html/HTMLLinkElement.h (left): https://codereview.chromium.org/241113002/diff/1/Source/core/html/HTMLLinkElement.h#oldcode147 Source/core/html/HTMLLinkElement.h:147: bool importOwnsLoader() const; This one is pretty recent, CCing ...
6 years, 8 months ago (2014-04-17 21:26:31 UTC) #2
Hajime Morrita
On 2014/04/17 21:26:31, adamk wrote: > https://codereview.chromium.org/241113002/diff/1/Source/core/html/HTMLLinkElement.h > File Source/core/html/HTMLLinkElement.h (left): > > https://codereview.chromium.org/241113002/diff/1/Source/core/html/HTMLLinkElement.h#oldcode147 > ...
6 years, 8 months ago (2014-04-17 21:35:19 UTC) #3
adamk
lgtm
6 years, 8 months ago (2014-04-18 17:59:48 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-18 18:00:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/241113002/1
6 years, 8 months ago (2014-04-18 18:00:39 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 18:10:36 UTC) #7
Message was sent while issue was closed. 
Change committed as 171959

Powered by Google App Engine
This is Rietveld 408576698