Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Issue 2411113003: Remove stl_util's deletion functions from tab_strip_model, and do other modernization. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions from tab_strip_model, and do other modernization. BUG=555865, 655021 Committed: https://crrev.com/e59e943420412def899ad2bbf7a496050071b549 Cr-Commit-Position: refs/heads/master@{#425041}

Patch Set 1 #

Total comments: 5

Patch Set 2 : {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -70 lines) Patch
M chrome/browser/ui/tabs/tab_strip_model.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 26 chunks +62 lines, -65 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Avi (use Gerrit)
4 years, 2 months ago (2016-10-12 22:19:20 UTC) #4
sky
LGTM with more {} https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_strip_model.cc File chrome/browser/ui/tabs/tab_strip_model.cc (right): https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_strip_model.cc#newcode525 chrome/browser/ui/tabs/tab_strip_model.cc:525: for (const auto& data : ...
4 years, 2 months ago (2016-10-13 00:11:05 UTC) #7
Avi (use Gerrit)
https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_strip_model.cc File chrome/browser/ui/tabs/tab_strip_model.cc (right): https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_strip_model.cc#newcode525 chrome/browser/ui/tabs/tab_strip_model.cc:525: for (const auto& data : contents_data_) On 2016/10/13 00:11:05, ...
4 years, 2 months ago (2016-10-13 15:00:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411113003/20001
4 years, 2 months ago (2016-10-13 15:01:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 15:37:51 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:41:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e59e943420412def899ad2bbf7a496050071b549
Cr-Commit-Position: refs/heads/master@{#425041}

Powered by Google App Engine
This is Rietveld 408576698