Remove stl_util's deletion functions from tab_strip_model, and do other modernization.

Remove stl_util's deletion functions from tab_strip_model, and do other modernization.

BUG=555865, 655021
Committed: https://crrev.com/e59e943420412def899ad2bbf7a496050071b549
Cr-Commit-Position: refs/heads/master@{#425041}

[Avi (use Gerrit), 2016-10-12 21:25:09]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 21:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-12 22:19:19]

avi@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:33:05]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-13 00:11:05]

LGTM with more {}

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_strip_model.cc (right):

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model.cc:525: for (const auto& data :
contents_data_)
Please use a {} here

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model.cc:1239: if (contents)
use {}

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model.cc:1266: if
(!selection_model().Equals(old_model))
use {}

[Avi (use Gerrit), 2016-10-13 15:00:50]

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
File chrome/browser/ui/tabs/tab_strip_model.cc (right):

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model.cc:525: for (const auto& data :
contents_data_)
On 2016/10/13 00:11:05, sky wrote:
> Please use a {} here

Done.

https://codereview.chromium.org/2411113003/diff/1/chrome/browser/ui/tabs/tab_...
chrome/browser/ui/tabs/tab_strip_model.cc:1239: if (contents)
On 2016/10/13 00:11:05, sky wrote:
> use {}

Done.

[Avi (use Gerrit), 2016-10-13 15:01:09]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-10-13 15:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2411113003/#ps20001
(title: "{}")

[commit-bot: I haz the power, 2016-10-13 15:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:37:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 15:41:39]

Description was changed from

==========
Remove stl_util's deletion functions from tab_strip_model, and do other
modernization.

BUG=555865, 655021
==========

to

==========
Remove stl_util's deletion functions from tab_strip_model, and do other
modernization.

BUG=555865, 655021

Committed: https://crrev.com/e59e943420412def899ad2bbf7a496050071b549
Cr-Commit-Position: refs/heads/master@{#425041}
==========

[commit-bot: I haz the power, 2016-10-13 15:41:40]

Patchset 2 (id:??) landed as
https://crrev.com/e59e943420412def899ad2bbf7a496050071b549
Cr-Commit-Position: refs/heads/master@{#425041}