Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8141)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.h

Issue 2411113003: Remove stl_util's deletion functions from tab_strip_model, and do other modernization. (Closed)
Patch Set: {} Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_strip_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model.h
diff --git a/chrome/browser/ui/tabs/tab_strip_model.h b/chrome/browser/ui/tabs/tab_strip_model.h
index fd49bdb011a50799e4f3525c6648bcc22df4847a..703850fa09c40f17c2a67097832ee230c11fd887 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.h
+++ b/chrome/browser/ui/tabs/tab_strip_model.h
@@ -518,7 +518,7 @@ class TabStripModel {
// Returns true if the tab represented by the specified data has an opener
// that matches the specified one. If |use_group| is true, then this will
// fall back to check the group relationship as well.
- static bool OpenerMatches(const WebContentsData* data,
+ static bool OpenerMatches(const std::unique_ptr<WebContentsData>& data,
const content::WebContents* opener,
bool use_group);
@@ -530,8 +530,7 @@ class TabStripModel {
TabStripModelDelegate* delegate_;
// The WebContents data currently hosted within this TabStripModel.
- typedef std::vector<WebContentsData*> WebContentsDataVector;
- WebContentsDataVector contents_data_;
+ std::vector<std::unique_ptr<WebContentsData>> contents_data_;
// A profile associated with this TabStripModel.
Profile* profile_;
@@ -544,8 +543,7 @@ class TabStripModel {
std::unique_ptr<TabStripModelOrderController> order_controller_;
// Our observers.
- typedef base::ObserverList<TabStripModelObserver> TabStripModelObservers;
- TabStripModelObservers observers_;
+ base::ObserverList<TabStripModelObserver> observers_;
ui::ListSelectionModel selection_model_;
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_strip_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698