Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2411073002: [css-flexbox] Remove unnecessary call to adjustAlignmentForChild (Closed)

Created:
4 years, 2 months ago by cbiesinger
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Remove unnecessary call to adjustAlignmentForChild adjustAlignmentForChild does nothing if child.isOutOfFlowPositioned(), so no need to call it and confuse readers of this function. R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/f75f45421357783b552430f49af2af7ea95f0666 Cr-Commit-Position: refs/heads/master@{#424580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
cbiesinger
4 years, 2 months ago (2016-10-11 20:43:21 UTC) #1
eae
LGTM
4 years, 2 months ago (2016-10-11 21:14:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411073002/1
4 years, 2 months ago (2016-10-11 21:16:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 22:47:28 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 22:50:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f75f45421357783b552430f49af2af7ea95f0666
Cr-Commit-Position: refs/heads/master@{#424580}

Powered by Google App Engine
This is Rietveld 408576698