third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 2411073002: [css-flexbox] Remove unnecessary call to adjustAlignmentForChild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2411073002: [css-flexbox] Remove unnecessary call to adjustAlignmentForChild (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index cd218d051f141b11e65b109f727bc02fe4f3720e..874296cb83f23c3c2e2bd4ade2e3b398c052fab7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -2157,8 +2157,6 @@ void LayoutFlexibleBox::alignChildren(const Vector<LineContext>& lineContexts,

if (child == childToExclude)

continue;

if (child->isOutOfFlowPositioned()) {

- if (style()->flexWrap() == FlexWrapReverse)

- adjustAlignmentForChild(*child, lineCrossAxisExtent);

continue;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »