Issue 2411043002: Don't show download button for HLS streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2411043002: Don't show download button for HLS streams (Closed)

Created:
4 years, 2 months ago by qinmin

Modified:
4 years, 2 months ago

Reviewers:
mlamouri (slow - plz ping)

CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, Srirama, vcarbune.chromium

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't show download button for HLS streams Downloading the m3u8 file isn't useful to user. TBR=mlamouri@chromium.org BUG=654507 Review-Url: https://codereview.chromium.org/2400293003 Cr-Commit-Position: refs/heads/master@{#424291} (cherry picked from commit e43859889b1cac0f6ba7d1855cb8e7753c8f89ba) Committed: https://chromium.googlesource.com/chromium/src/+/07b38a3f37f9578807bf73661f084f23f0812f32

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)			Patch
M	third_party/WebKit/Source/core/html/HTMLMediaElement.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

qinmin

4 years, 2 months ago (2016-10-11 19:59:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
07b38a3f37f9578807bf73661f084f23f0812f32 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages