Don't show download button for HLS streams

Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507
Committed: https://crrev.com/e43859889b1cac0f6ba7d1855cb8e7753c8f89ba
Cr-Commit-Position: refs/heads/master@{#424291}

[qinmin, 2016-10-07 19:38:31]

qinmin@chromium.org changed reviewers:
+ mlamouri@chromium.org

[qinmin, 2016-10-07 19:38:31]

PTAL

[mlamouri (slow - plz ping), 2016-10-08 09:57:54]

Thanks! I completely forgot about this. Can you open a bug? We need to merge
this fix in M55.

https://codereview.chromium.org/2400293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
(right):

https://codereview.chromium.org/2400293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp:678: if
(url.getString().contains("m3u8"))
Can you make this a static method on HTMLMediaElement like isMediaStreamURL:
isHLSURL() so we can re-use it.

It would be great if we could make the check similar to
https://cs.chromium.org/chromium/src/media/base/android/media_codec_util.cc?l...

[qinmin, 2016-10-10 19:16:36]

Description was changed from

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.
==========

to

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507
==========

[qinmin, 2016-10-10 19:17:42]

https://codereview.chromium.org/2400293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
(right):

https://codereview.chromium.org/2400293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp:678: if
(url.getString().contains("m3u8"))
On 2016/10/08 09:57:54, mlamouri wrote:
> Can you make this a static method on HTMLMediaElement like isMediaStreamURL:
> isHLSURL() so we can re-use it.
> 
> It would be great if we could make the check similar to
>
https://cs.chromium.org/chromium/src/media/base/android/media_codec_util.cc?l...

Done. IsHLSURL is more correct compared to IsHLSPath, according to UMA

[mlamouri (slow - plz ping), 2016-10-10 20:37:26]

lgtm

[qinmin, 2016-10-10 20:49:33]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:58:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qinmin, 2016-10-10 22:25:05]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-10-10 22:25:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2400293003/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-10-10 22:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:47:23]

Description was changed from

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507
==========

to

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507
==========

[commit-bot: I haz the power, 2016-10-10 23:47:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-10 23:51:38]

Description was changed from

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507
==========

to

==========
Don't show download button for HLS streams

Downloading the m3u8 file isn't useful to user.

BUG=654507

Committed: https://crrev.com/e43859889b1cac0f6ba7d1855cb8e7753c8f89ba
Cr-Commit-Position: refs/heads/master@{#424291}
==========

[commit-bot: I haz the power, 2016-10-10 23:51:39]

Patchset 3 (id:??) landed as
https://crrev.com/e43859889b1cac0f6ba7d1855cb8e7753c8f89ba
Cr-Commit-Position: refs/heads/master@{#424291}