Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2411003003: Save an early test summary in case the test launcher crashes or gets killed (Closed)

Created:
4 years, 2 months ago by Paweł Hajdan Jr.
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Save an early test summary in case the test launcher crashes or gets killed This may turn some infra failures (purple) into INVALID_TEST_RESULTS (red) in case the test launcher is for example early terminated on swarming. See bug for more details. BUG=649831 Committed: https://crrev.com/5dc1ee3fccf13062e1ee9b1fbb25189f617c74c8 Cr-Commit-Position: refs/heads/master@{#424709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M base/test/launcher/test_results_tracker.h View 1 chunk +5 lines, -2 lines 0 comments Download
M base/test/launcher/test_results_tracker.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Paweł Hajdan Jr.
4 years, 2 months ago (2016-10-11 20:12:08 UTC) #4
Dirk Pranke
Can you update the CL description with more information about what problem this is solving ...
4 years, 2 months ago (2016-10-11 21:26:11 UTC) #7
jam
lgtm
4 years, 2 months ago (2016-10-11 21:26:53 UTC) #8
Paweł Hajdan Jr.
On 2016/10/11 at 21:26:11, dpranke wrote: > Can you update the CL description with more ...
4 years, 2 months ago (2016-10-12 10:41:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411003003/1
4 years, 2 months ago (2016-10-12 10:41:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 10:46:39 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 10:48:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dc1ee3fccf13062e1ee9b1fbb25189f617c74c8
Cr-Commit-Position: refs/heads/master@{#424709}

Powered by Google App Engine
This is Rietveld 408576698