Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: base/test/launcher/test_results_tracker.cc

Issue 2411003003: Save an early test summary in case the test launcher crashes or gets killed (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/launcher/test_results_tracker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/launcher/test_results_tracker.cc
diff --git a/base/test/launcher/test_results_tracker.cc b/base/test/launcher/test_results_tracker.cc
index aadf35069850a57569e2e8c59c9d23a8a95b1311..a8611aee38f70bccb07c50484a3cab5f9e02ca69 100644
--- a/base/test/launcher/test_results_tracker.cc
+++ b/base/test/launcher/test_results_tracker.cc
@@ -296,13 +296,18 @@ void TestResultsTracker::AddGlobalTag(const std::string& tag) {
global_tags_.insert(tag);
}
-bool TestResultsTracker::SaveSummaryAsJSON(const FilePath& path) const {
+bool TestResultsTracker::SaveSummaryAsJSON(
+ const FilePath& path,
+ const std::vector<std::string>& additional_tags) const {
std::unique_ptr<DictionaryValue> summary_root(new DictionaryValue);
std::unique_ptr<ListValue> global_tags(new ListValue);
for (const auto& global_tag : global_tags_) {
global_tags->AppendString(global_tag);
}
+ for (const auto& tag : additional_tags) {
+ global_tags->AppendString(tag);
+ }
summary_root->Set("global_tags", std::move(global_tags));
std::unique_ptr<ListValue> all_tests(new ListValue);
« no previous file with comments | « base/test/launcher/test_results_tracker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698