Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2410873003: Implement MarkRequestCompleted. (Closed)

Created:
4 years, 2 months ago by Pete Williamson
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Implement MarkRequestCompleted. When the foreground tab finishes a request, it will let us know, and we need to send out the observer notification. This code catches the foreground request completing, and calls the observer with SUCCESS after removing the request, and starting the next available request. BUG=652889 Review-Url: https://codereview.chromium.org/2409823002 Cr-Commit-Position: refs/heads/master@{#424346} (cherry picked from commit b1c4cc221dd01af09ceaf1eba05735046bd46d0b) Committed: https://chromium.googlesource.com/chromium/src/+/b6d6eaef2b28bbfa7cc0be5ab099cdaf0570f2c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M components/offline_pages/background/request_coordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 2 chunks +16 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
4 years, 2 months ago (2016-10-11 23:24:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6d6eaef2b28bbfa7cc0be5ab099cdaf0570f2c9.

Powered by Google App Engine
This is Rietveld 408576698