Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2409823002: Implement MarkRequestCompleted. (Closed)

Created:
4 years, 2 months ago by Pete Williamson
Modified:
4 years, 2 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org, dougarnett
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement MarkRequestCompleted. When the foreground tab finishes a request, it will let us know, and we need to send out the observer notification. This code catches the foreground request completing, and calls the observer with SUCCESS after removing the request, and starting the next available request. BUG=652889 Committed: https://crrev.com/b1c4cc221dd01af09ceaf1eba05735046bd46d0b Cr-Commit-Position: refs/heads/master@{#424346}

Patch Set 1 #

Patch Set 2 : rebase-update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M components/offline_pages/background/request_coordinator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 2 chunks +16 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Pete Williamson
4 years, 2 months ago (2016-10-10 22:18:50 UTC) #2
Dmitry Titov
Looks ok, thanks! lgtm
4 years, 2 months ago (2016-10-11 00:05:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409823002/20001
4 years, 2 months ago (2016-10-11 01:01:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 02:38:21 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 02:42:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1c4cc221dd01af09ceaf1eba05735046bd46d0b
Cr-Commit-Position: refs/heads/master@{#424346}

Powered by Google App Engine
This is Rietveld 408576698