Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2410813002: Prune most of the deprecated functions from CompositeEditCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune most of the deprecated functions from CompositeEditCommand BUG=647219, 651373 Committed: https://crrev.com/cc8c3088a0fb49c131d9a6e472d8020946f1a161 Cr-Commit-Position: refs/heads/master@{#424648}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -46 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 24 chunks +72 lines, -46 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-11 10:11:02 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-12 02:10:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410813002/1
4 years, 2 months ago (2016-10-12 02:11:08 UTC) #9
yosin_UTC9
https://codereview.chromium.org/2410813002/diff/1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp (right): https://codereview.chromium.org/2410813002/diff/1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp#newcode860 third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:860: VisiblePosition visibleUpstreamPos = BTW, should we replace |VisiblePosition| to ...
4 years, 2 months ago (2016-10-12 02:12:06 UTC) #10
Xiaocheng
https://codereview.chromium.org/2410813002/diff/1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp (right): https://codereview.chromium.org/2410813002/diff/1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp#newcode860 third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:860: VisiblePosition visibleUpstreamPos = On 2016/10/12 at 02:12:06, Yosi_UTC9 wrote: ...
4 years, 2 months ago (2016-10-12 02:15:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 02:16:54 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 02:19:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc8c3088a0fb49c131d9a6e472d8020946f1a161
Cr-Commit-Position: refs/heads/master@{#424648}

Powered by Google App Engine
This is Rietveld 408576698