Ensure valid input for CompositeEditCommand::moveParagraph[s]

Ensure valid input for CompositeEditCommand::moveParagraph[s]

This patch ensured valid VisiblePositions as input arguments to
CompositeEditCommand's moveParagraph() and moveParagraphs(), and hence,
prunes the remaining deprecated functions therein.

BUG=648949
Committed: https://crrev.com/5f0ab5ec41d132eb4ff36460e4f05c110dda17f6
Cr-Commit-Position: refs/heads/master@{#424682}

[Xiaocheng, 2016-10-11 10:00:28]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 10:00:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 11:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 11:12:37]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-12 02:20:45]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-12 02:20:46]

PTAL.

[yosin_UTC9, 2016-10-12 02:29:47]

lgtm w/ trial suggestion.

https://codereview.chromium.org/2405223002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
(right):

https://codereview.chromium.org/2405223002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp:477: //
Dirty hacks making start and end valid again.
(^_^)
How about change |start| and |end| to |PositionWithAffinity| for removing "Dirty
hack" comment?

[Xiaocheng, 2016-10-12 04:16:29]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 04:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-12 04:41:17]

On 2016/10/12 at 02:29:47, yosin wrote:
> lgtm w/ trial suggestion.
> 
>
https://codereview.chromium.org/2405223002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
(right):
> 
>
https://codereview.chromium.org/2405223002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp:477: //
Dirty hacks making start and end valid again.
> (^_^)
> How about change |start| and |end| to |PositionWithAffinity| for removing
"Dirty hack" comment?

Done. Still, there are too many such patterns in editing/commands.

I think it would be a good time to remove them after we have stopped
EditCommand's starting and ending selection from storing a VisibleSelection.

[commit-bot: I haz the power, 2016-10-12 06:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 06:06:05]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-12 06:20:19]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-12 06:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2405223002/#ps20001
(title: "Remove the dirty hacks")

[commit-bot: I haz the power, 2016-10-12 06:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 06:25:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 06:27:29]

Description was changed from

==========
Ensure valid input for CompositeEditCommand::moveParagraph[s]

This patch ensured valid VisiblePositions as input arguments to
CompositeEditCommand's moveParagraph() and moveParagraphs(), and hence,
prunes the remaining deprecated functions therein.

BUG=648949
==========

to

==========
Ensure valid input for CompositeEditCommand::moveParagraph[s]

This patch ensured valid VisiblePositions as input arguments to
CompositeEditCommand's moveParagraph() and moveParagraphs(), and hence,
prunes the remaining deprecated functions therein.

BUG=648949

Committed: https://crrev.com/5f0ab5ec41d132eb4ff36460e4f05c110dda17f6
Cr-Commit-Position: refs/heads/master@{#424682}
==========

[commit-bot: I haz the power, 2016-10-12 06:27:30]

Patchset 2 (id:??) landed as
https://crrev.com/5f0ab5ec41d132eb4ff36460e4f05c110dda17f6
Cr-Commit-Position: refs/heads/master@{#424682}