Check whether touch event was dispatched succussfully in Ime Test.

Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964
Committed: https://crrev.com/52b14230af2ce6806a3ec1006e4b76a65b1d7db9
Cr-Commit-Position: refs/heads/master@{#425207}

[yabinh, 2016-10-13 06:55:09]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 06:55:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-10-13 06:57:57]

Description was changed from

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add add assertion in Ime test to
check whether that's the case.

BUG=628964
==========

to

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964
==========

[yabinh, 2016-10-13 06:57:57]

yabinh@chromium.org changed reviewers:
+ aelias@chromium.org, changwan@chromium.org

[yabinh, 2016-10-13 06:58:48]

Changwan@, can you take a look at this patch?

[Changwan Ryu, 2016-10-13 07:14:22]

lgtm w/ nits

https://codereview.chromium.org/2410773008/diff/1/content/public/test/android...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://codereview.chromium.org/2410773008/diff/1/content/public/test/android...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:203:
private static Boolean dispatchTouchEvent(final View view, final MotionEvent
event) {
boolean

[yabinh, 2016-10-13 07:16:50]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-10-13 07:17:10]

https://codereview.chromium.org/2410773008/diff/1/content/public/test/android...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://codereview.chromium.org/2410773008/diff/1/content/public/test/android...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:203:
private static Boolean dispatchTouchEvent(final View view, final MotionEvent
event) {
On 2016/10/13 07:14:22, Changwan Ryu wrote:
> boolean

Done.

[commit-bot: I haz the power, 2016-10-13 07:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:45:55]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-10-13 18:31:57]

lgtm

[yabinh, 2016-10-13 23:55:33]

The CQ bit was checked by yabinh@chromium.org

[yabinh, 2016-10-13 23:55:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
changwan@chromium.org
Link to the patchset: https://codereview.chromium.org/2410773008/#ps20001
(title: "Address changwan@'s review")

[commit-bot: I haz the power, 2016-10-13 23:55:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 00:03:48]

Description was changed from

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964
==========

to

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964
==========

[commit-bot: I haz the power, 2016-10-14 00:03:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 00:06:30]

Description was changed from

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964
==========

to

==========
Check whether touch event was dispatched succussfully in Ime Test.

Ime tests are flaky on trybot for the same reason: input conneciton is
null. The only way we found to repro it locally is to lock the screen
before running the test. In that case, the node is not focused, and it
fails to dispatch touch event. So we add assertion in Ime test to
check whether that's the case.

BUG=628964

Committed: https://crrev.com/52b14230af2ce6806a3ec1006e4b76a65b1d7db9
Cr-Commit-Position: refs/heads/master@{#425207}
==========

[commit-bot: I haz the power, 2016-10-14 00:06:31]

Patchset 2 (id:??) landed as
https://crrev.com/52b14230af2ce6806a3ec1006e4b76a65b1d7db9
Cr-Commit-Position: refs/heads/master@{#425207}