content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java - Issue 2410773008: Check whether touch event was dispatched succussfully in Ime Test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

Issue 2410773008: Check whether touch event was dispatched succussfully in Ime Test. (Closed)

Patch Set: Address changwan@'s review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

index 9b457decf2d1f213de8e97bde8d64229128739e6..4429cf7a93a2df2a3b5478b110f4f2ce1d78c7f2 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

@@ -231,12 +231,13 @@ public class DOMUtils {

* @param viewCore The ContentViewCore in which the node lives.

* @param nodeId The id of the node.

- public static void clickNode(ActivityInstrumentationTestCase2 activityTestCase,

+ public static boolean clickNode(ActivityInstrumentationTestCase2 activityTestCase,

final ContentViewCore viewCore, String nodeId)

throws InterruptedException, TimeoutException {

scrollNodeIntoView(viewCore.getWebContents(), nodeId);

int[] clickTarget = getClickTargetForNode(viewCore, nodeId);

- TouchCommon.singleClickView(viewCore.getContainerView(), clickTarget[0], clickTarget[1]);

+ return TouchCommon.singleClickView(

+ viewCore.getContainerView(), clickTarget[0], clickTarget[1]);

}

/**