Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2410743002: Remove the mojo serial interfaces and related infrastructure. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the mojo serial interfaces and related infrastructure. BUG=389016 Committed: https://crrev.com/17fe79c1ca8e9735ca11d057c96a732ba1b7e7fb Cr-Commit-Position: refs/heads/master@{#424579}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8006 lines) Patch
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M device/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/serial/BUILD.gn View 3 chunks +0 lines, -17 lines 0 comments Download
A + device/serial/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
D device/serial/data_receiver.h View 1 chunk +0 lines, -103 lines 0 comments Download
D device/serial/data_receiver.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D device/serial/data_sender.h View 1 chunk +0 lines, -93 lines 0 comments Download
D device/serial/data_sender.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D device/serial/data_sink_receiver.h View 1 chunk +0 lines, -114 lines 0 comments Download
D device/serial/data_sink_receiver.cc View 1 chunk +0 lines, -288 lines 0 comments Download
D device/serial/data_sink_unittest.cc View 1 chunk +0 lines, -419 lines 0 comments Download
D device/serial/data_source_sender.h View 1 chunk +0 lines, -103 lines 0 comments Download
D device/serial/data_source_sender.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D device/serial/data_source_unittest.cc View 1 chunk +0 lines, -263 lines 0 comments Download
D device/serial/data_stream.mojom View 1 chunk +0 lines, -44 lines 0 comments Download
D device/serial/data_stream_serialization.mojom View 1 chunk +0 lines, -49 lines 0 comments Download
M device/serial/serial.mojom View 2 chunks +0 lines, -27 lines 0 comments Download
D device/serial/serial_connection.h View 1 chunk +0 lines, -55 lines 0 comments Download
D device/serial/serial_connection.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D device/serial/serial_connection_factory.h View 1 chunk +0 lines, -54 lines 0 comments Download
D device/serial/serial_connection_factory.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D device/serial/serial_connection_unittest.cc View 1 chunk +0 lines, -343 lines 0 comments Download
D device/serial/serial_serialization.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
D device/serial/serial_service_impl.h View 1 chunk +0 lines, -59 lines 0 comments Download
D device/serial/serial_service_impl.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/serial/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 4 chunks +7 lines, -46 lines 0 comments Download
D extensions/browser/api/serial/serial_service_factory.h View 1 chunk +0 lines, -22 lines 0 comments Download
D extensions/browser/api/serial/serial_service_factory.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M extensions/browser/mojo/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/mojo/service_registration.cc View 4 chunks +2 lines, -8 lines 0 comments Download
D extensions/browser/mojo/stash_backend.h View 1 chunk +0 lines, -57 lines 0 comments Download
D extensions/browser/mojo/stash_backend.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/mojo/stash.mojom View 1 chunk +0 lines, -34 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D extensions/renderer/api/serial/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D extensions/renderer/api/serial/data_receiver_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D extensions/renderer/api/serial/data_sender_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D extensions/renderer/api/serial/serial_api_unittest.cc View 1 chunk +0 lines, -741 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +0 lines, -21 lines 0 comments Download
D extensions/renderer/mojo/stash_client_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D extensions/renderer/resources/data_receiver.js View 1 chunk +0 lines, -336 lines 0 comments Download
D extensions/renderer/resources/data_sender.js View 1 chunk +0 lines, -335 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 2 chunks +0 lines, -10 lines 0 comments Download
D extensions/renderer/resources/serial_custom_bindings.js View 1 chunk +0 lines, -117 lines 0 comments Download
D extensions/renderer/resources/serial_service.js View 1 chunk +0 lines, -554 lines 0 comments Download
D extensions/renderer/resources/stash_client.js View 1 chunk +0 lines, -168 lines 0 comments Download
D extensions/test/data/data_receiver_unittest.js View 1 chunk +0 lines, -175 lines 0 comments Download
D extensions/test/data/data_sender_unittest.js View 1 chunk +0 lines, -291 lines 0 comments Download
D extensions/test/data/serial_unittest.js View 1 chunk +0 lines, -918 lines 0 comments Download
D extensions/test/data/stash_client_unittest.js View 1 chunk +0 lines, -77 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
Sam McNally
4 years, 2 months ago (2016-10-11 06:57:04 UTC) #7
Ken Rockot(use gerrit already)
8000 lines! LGTM
4 years, 2 months ago (2016-10-11 19:02:26 UTC) #8
Sam McNally
+dcheng for the mojom.
4 years, 2 months ago (2016-10-11 22:35:30 UTC) #10
dcheng
mojom lgtm
4 years, 2 months ago (2016-10-11 22:36:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410743002/20001
4 years, 2 months ago (2016-10-11 22:38:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-11 22:46:32 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 22:50:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17fe79c1ca8e9735ca11d057c96a732ba1b7e7fb
Cr-Commit-Position: refs/heads/master@{#424579}

Powered by Google App Engine
This is Rietveld 408576698