Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2409073002: Use mojo from the PDF extension instead of using an extension API.

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mojo from the PDF extension instead of using an extension API. This changes the two mime handler guests - the PDF extension and an extension used for testing - to use mojo directly to obtain the stream details. It also restricts adding mojo bindings to only extensions that have the mojoPrivate API feature. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -981 lines) Patch
M chrome/browser/resources/pdf/browser_api.js View 6 chunks +76 lines, -45 lines 0 comments Download
M chrome/test/data/extensions/api_test/mime_handler_view/index.js View 4 chunks +39 lines, -9 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/_api_features.json View 2 chunks +5 lines, -6 lines 0 comments Download
D extensions/common/api/mime_handler_private.idl View 1 chunk +0 lines, -41 lines 0 comments Download
M extensions/renderer/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D extensions/renderer/api/mojo_private/mojo_private_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D extensions/renderer/api_test_base.h View 1 chunk +0 lines, -125 lines 0 comments Download
D extensions/renderer/api_test_base.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D extensions/renderer/api_test_base_unittest.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +4 lines, -5 lines 0 comments Download
D extensions/renderer/mojo/keep_alive_client_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M extensions/renderer/resources/binding.js View 1 chunk +0 lines, -30 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/renderer/resources/keep_alive.js View 1 chunk +0 lines, -41 lines 0 comments Download
D extensions/renderer/resources/mime_handler_private_custom_bindings.js View 1 chunk +0 lines, -75 lines 0 comments Download
D extensions/test/data/api_test_base_unittest.js View 1 chunk +0 lines, -65 lines 0 comments Download
D extensions/test/data/keep_alive_client_unittest.js View 1 chunk +0 lines, -44 lines 0 comments Download
D extensions/test/data/mojo_private_unittest.js View 1 chunk +0 lines, -54 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (5 generated)
Sam McNally
Description was changed from ========== Use mojo from the PDF extension instead of using an ...
4 years, 2 months ago (2016-10-11 07:03:18 UTC) #1
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-11 07:03:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409073002/1
4 years, 2 months ago (2016-10-11 07:03:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-11 07:14:26 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 07:14:27 UTC) #5
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698