Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2410663002: Fixing issue that causes STUN throttle rate to be off by a factor of 1000. (Closed)

Created:
4 years, 2 months ago by Taylor_Brandstetter
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fixing issue that causes STUN throttle rate to be off by a factor of 1000. The limit is supposed to be 256kbps, but it was actually effectively 256Mbps due to dividing a microsecond count by "microseconds per millisecond" instead of "per second". BUG=chromium:622323 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2398603004 Cr-Commit-Position: refs/heads/master@{#423902} (cherry picked from commit e9e3f35d8eba2a4f0d88df274fc4eca48e811083)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -15 lines) Patch
M content/browser/renderer_host/p2p/socket_host_throttler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 3 chunks +70 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Taylor_Brandstetter
Hi Sergey; this is the same CL you reviewed earlier, being merged to M55. I'm ...
4 years, 2 months ago (2016-10-11 00:43:03 UTC) #2
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-11 17:28:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410663002/1
4 years, 2 months ago (2016-10-11 17:29:24 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 2 months ago (2016-10-11 17:29:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410663002/1
4 years, 2 months ago (2016-10-11 17:32:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:39:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698