Fixing issue that causes STUN throttle rate to be off by a factor of 1000.

Fixing issue that causes STUN throttle rate to be off by a factor of 1000.

The limit is supposed to be 256kbps, but it was actually effectively
256Mbps due to dividing a microsecond count by "microseconds per
millisecond" instead of "per second".

BUG=chromium:622323
Committed: https://crrev.com/e9e3f35d8eba2a4f0d88df274fc4eca48e811083
Cr-Commit-Position: refs/heads/master@{#423902}

[Taylor_Brandstetter, 2016-10-06 04:57:36]

deadbeef@chromium.org changed reviewers:
+ guidou@chromium.org, sergeyu@chromium.org

[Taylor_Brandstetter, 2016-10-06 04:57:36]

PTAL

[pthatcher2, 2016-10-06 16:48:03]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2016-10-06 16:48:04]

lgtm

Wow.  Good job noticing and fixing this.

[Guido Urdaneta, 2016-10-06 16:50:08]

lgtm

[Taylor_Brandstetter, 2016-10-06 22:55:25]

Test is failing on the debug bot due to this issue:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6490

Not sure what to do about it at the moment. I think the test was only passing
before because it never attempted to advance the clock.

[Sergey Ulanov, 2016-10-07 00:16:28]

lgtm

[Sergey Ulanov, 2016-10-07 00:18:21]

On 2016/10/06 22:55:25, Taylor_Brandstetter wrote:
> Test is failing on the debug bot due to this issue:
> https://bugs.chromium.org/p/webrtc/issues/detail?id=6490
> 
> Not sure what to do about it at the moment. I think the test was only passing
> before because it never attempted to advance the clock.

I think the right fix is to make webrtc or webrtc base a component. Maybe
disable the test short-term to unblock this change.

[Taylor_Brandstetter, 2016-10-07 01:12:39]

On 2016/10/07 00:18:21, Sergey Ulanov wrote:
> On 2016/10/06 22:55:25, Taylor_Brandstetter wrote:
> > Test is failing on the debug bot due to this issue:
> > https://bugs.chromium.org/p/webrtc/issues/detail?id=6490
> > 
> > Not sure what to do about it at the moment. I think the test was only
passing
> > before because it never attempted to advance the clock.
> 
> I think the right fix is to make webrtc or webrtc base a component. Maybe
> disable the test short-term to unblock this change.

Disabling the test short-term seems fine. At least things aren't being made any
worse, and the test will get run on non-component builds.

[Taylor_Brandstetter, 2016-10-07 01:12:55]

The CQ bit was checked by deadbeef@chromium.org

[Taylor_Brandstetter, 2016-10-07 01:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
pthatcher@chromium.org, sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2398603004/#ps60001
(title: "Disabling new test on component builds.")

[commit-bot: I haz the power, 2016-10-07 01:13:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 03:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 03:19:21]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Taylor_Brandstetter, 2016-10-07 17:00:07]

The CQ bit was checked by deadbeef@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:50:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-07 17:53:06]

Description was changed from

==========
Fixing issue that causes STUN throttle rate to be off by a factor of 1000.

The limit is supposed to be 256kbps, but it was actually effectively
256Mbps due to dividing a microsecond count by "microseconds per
millisecond" instead of "per second".

BUG=chromium:622323
==========

to

==========
Fixing issue that causes STUN throttle rate to be off by a factor of 1000.

The limit is supposed to be 256kbps, but it was actually effectively
256Mbps due to dividing a microsecond count by "microseconds per
millisecond" instead of "per second".

BUG=chromium:622323

Committed: https://crrev.com/e9e3f35d8eba2a4f0d88df274fc4eca48e811083
Cr-Commit-Position: refs/heads/master@{#423902}
==========

[commit-bot: I haz the power, 2016-10-07 17:53:06]

Patchset 4 (id:??) landed as
https://crrev.com/e9e3f35d8eba2a4f0d88df274fc4eca48e811083
Cr-Commit-Position: refs/heads/master@{#423902}