Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2410633002: Moves PanelFrameView to common (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves PanelFrameView to common And wires up for mash. BUG=614362 TEST=none R=msw@chromium.org Committed: https://crrev.com/e80dede2efd6e1e6598b5b124d049f75082928eb Cr-Commit-Position: refs/heads/master@{#424321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -259 lines) Patch
M ash/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/wm/panels/panel_frame_view.h View 3 chunks +5 lines, -3 lines 0 comments Download
A + ash/common/wm/panels/panel_frame_view.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/mus/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/panel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/panels/panel_frame_view.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ash/wm/panels/panel_frame_view.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 2 months ago (2016-10-10 22:19:54 UTC) #1
msw
lgtm
4 years, 2 months ago (2016-10-10 23:50:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410633002/1
4 years, 2 months ago (2016-10-11 00:07:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 01:13:28 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:22:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e80dede2efd6e1e6598b5b124d049f75082928eb
Cr-Commit-Position: refs/heads/master@{#424321}

Powered by Google App Engine
This is Rietveld 408576698