ash/mus/root_window_controller.cc - Issue 2410633002: Moves PanelFrameView to common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/mus/root_window_controller.cc

Issue 2410633002: Moves PanelFrameView to common (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/mus/root_window_controller.cc

diff --git a/ash/mus/root_window_controller.cc b/ash/mus/root_window_controller.cc

index cb4c25791bf0eb52ad7708df980538165d7c7c7e..0c5bdb6d140261868a5eefe7a42ae042f873bd43 100644

--- a/ash/mus/root_window_controller.cc

+++ b/ash/mus/root_window_controller.cc

@@ -90,7 +90,6 @@ shell::Connector* RootWindowController::GetConnector() {

ui::Window* RootWindowController::NewTopLevelWindow(

std::map<std::string, std::vector<uint8_t>>* properties) {

- // TODO(sky): panels need a different frame, http:://crbug.com/614362.

const bool provide_non_client_frame =

GetWindowType(*properties) == ui::mojom::WindowType::WINDOW ||

GetWindowType(*properties) == ui::mojom::WindowType::PANEL;

« no previous file with comments | « ash/mus/non_client_frame_controller.cc ('k') | ash/shell/panel_window.cc » ('j') | no next file with comments »