Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2410503002: Merge to M53: Don't post events on internal nodes in the accessibility tree on Android. (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2785_124
Target Ref:
refs/pending/branch-heads/2785_124
Project:
chromium
Visibility:
Public.

Description

Merge to M53: Don't post events on internal nodes in the accessibility tree on Android. Sometimes we get events on nodes in the internal accessibility tree that are not exposed on that platform or under all circumstances. On Android that led to an issue where after closing a SELECT pop-up, we got a focus event on the OPTION and subsequent navigation was trapped inside that control rather than outside it. The fix is to map the focus event to the topmost leaf ancestor, which in this case would be the SELECT element. BUG=652805 Review-Url: https://codereview.chromium.org/2397503002 Cr-Commit-Position: refs/heads/master@{#422944} (cherry picked from commit 7969d3a5bcf2af3fac57c3acef518298e8c48382) Committed: https://chromium.googlesource.com/chromium/src/+/1b6eb6de84f9ccf47005fb59351de98b0719a877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 2 months ago (2016-10-10 18:41:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b6eb6de84f9ccf47005fb59351de98b0719a877.

Powered by Google App Engine
This is Rietveld 408576698