Don't post events on internal nodes in the accessibility tree on Android.

Don't post events on internal nodes in the accessibility tree on Android.

Sometimes we get events on nodes in the internal accessibility tree that
are not exposed on that platform or under all circumstances. On Android
that led to an issue where after closing a SELECT pop-up, we got a focus
event on the OPTION and subsequent navigation was trapped inside that
control rather than outside it.

The fix is to map the focus event to the topmost leaf ancestor, which
in this case would be the SELECT element.

BUG=652805
Committed: https://crrev.com/7969d3a5bcf2af3fac57c3acef518298e8c48382
Cr-Commit-Position: refs/heads/master@{#422944}

[dmazzoni, 2016-10-04 19:38:52]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2016-10-04 19:38:57]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 19:39:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-10-04 19:56:15]

lgtm

https://codereview.chromium.org/2397503002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/2397503002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.cc:231: node
= parent;
Break? Are there leaves that have ancestor leaves?

[commit-bot: I haz the power, 2016-10-04 20:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:27:59]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-10-04 21:35:09]

https://codereview.chromium.org/2397503002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/2397503002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.cc:231: node
= parent;
On 2016/10/04 19:56:15, David Tseng wrote:
> Break? Are there leaves that have ancestor leaves?

In theory yes? I want this to behave as if you walked the tree.

[dmazzoni, 2016-10-04 21:35:14]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:35:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 21:42:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 21:44:12]

Description was changed from

==========
Don't post events on internal nodes in the accessibility tree on Android.

Sometimes we get events on nodes in the internal accessibility tree that
are not exposed on that platform or under all circumstances. On Android
that led to an issue where after closing a SELECT pop-up, we got a focus
event on the OPTION and subsequent navigation was trapped inside that
control rather than outside it.

The fix is to map the focus event to the topmost leaf ancestor, which
in this case would be the SELECT element.

BUG=652805
==========

to

==========
Don't post events on internal nodes in the accessibility tree on Android.

Sometimes we get events on nodes in the internal accessibility tree that
are not exposed on that platform or under all circumstances. On Android
that led to an issue where after closing a SELECT pop-up, we got a focus
event on the OPTION and subsequent navigation was trapped inside that
control rather than outside it.

The fix is to map the focus event to the topmost leaf ancestor, which
in this case would be the SELECT element.

BUG=652805

Committed: https://crrev.com/7969d3a5bcf2af3fac57c3acef518298e8c48382
Cr-Commit-Position: refs/heads/master@{#422944}
==========

[commit-bot: I haz the power, 2016-10-04 21:44:14]

Patchset 1 (id:??) landed as
https://crrev.com/7969d3a5bcf2af3fac57c3acef518298e8c48382
Cr-Commit-Position: refs/heads/master@{#422944}