Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2410403002: Remove the experimental navigator.storageQuota API (Closed)

Created:
4 years, 2 months ago by jsbell
Modified:
3 years, 10 months ago
Reviewers:
kinuko, chrishtr
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the experimental navigator.storageQuota API First we had (#1) - 2011 * window.webkitStorageInfo.queryUsageAndQuota() * window.webkitStorageInfo.requestQuota() status: stable, prefixed, Chrome only, deprecated, use counter: 0.1% spec: https://wiki.whatwg.org/wiki/Quota Then we added (#2) - 2012 * navigator.webkitTemporaryStorage.queryUsageAndQuota() * navigator.webkitTemporaryStorage.requestQuota() * navigator.webkitPersistentStorage.queryUsageAndQuota() * navigator.webkitPersistentStorage.requestQuota() status: stable, prefixed, Chrome only, use counter: 0.6% spec: https://www.w3.org/TR/2012/WD-quota-api-20120703/ Then we added (#3) - 2013 * navigator.storageQuota.queryInfo() * navigator.storageQuota.requestPersistentQuota() status: experimental, Chrome only spec: https://www.w3.org/TR/quota-api/ Most recently we've added (#4) - 2016 * navigator.storage.estimate() status: experimental, FF implemented and shipping in 51(?) spec: https://storage.spec.whatwg.org/ This time for sure, right? There seems to be cross browser traction on the last one (#4). This CL removes #3. BUG=332325 Review-Url: https://codereview.chromium.org/2410403002 Cr-Commit-Position: refs/heads/master@{#449668} Committed: https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3bccc5209bca7

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Factored out navigator consolidation #

Patch Set 6 : Decoupled #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -716 lines) Patch
D third_party/WebKit/LayoutTests/storage/quota/storagequota-query-info.html View 1 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/quota/storagequota-query-info-expected.txt View 1 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/quota/storagequota-request-persistent-quota.html View 1 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/quota/storagequota-request-persistent-quota-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 4 5 6 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h View 1 2 3 4 5 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp View 1 2 3 4 5 4 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.idl View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageInfo.idl View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageQuota.h View 2 3 4 5 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageQuota.cpp View 1 2 3 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageQuota.idl View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageQuotaCallbacksImpl.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/modules/quota/StorageQuotaCallbacksImpl.cpp View 1 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaClient.h View 1 2 3 4 5 6 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp View 1 2 3 4 5 6 2 chunks +9 lines, -45 lines 0 comments Download

Messages

Total messages: 33 (27 generated)
jsbell
FYI, I don't plan to propose landing this until after navigator.storage.estimate() hits stable, and I'm ...
4 years, 2 months ago (2016-10-11 23:57:41 UTC) #4
jsbell
Since Firefox is shipping navigator.storage.estimate() in 51 per https://developer.mozilla.org/en-US/Firefox/Releases/51 I guess it's time to look ...
3 years, 10 months ago (2017-02-10 00:57:11 UTC) #20
chrishtr
lgtm LGTM for json5.
3 years, 10 months ago (2017-02-10 00:59:08 UTC) #21
kinuko
Have been awaiting for this patch to land, thanks for working on this. LGTM!
3 years, 10 months ago (2017-02-10 01:14:53 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410403002/120001
3 years, 10 months ago (2017-02-10 17:25:00 UTC) #30
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 18:43:49 UTC) #33
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3...

Powered by Google App Engine
This is Rietveld 408576698