Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2410253002: GN: Fix flags writing for targets with unsupported PCHs (Closed)

Created:
4 years, 2 months ago by timn
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix flags writing for targets with unsupported PCHs This fixes an issue that led to empty compiler flags being written in the unusual case of a target with a PCH in conjunction with a toolchain that doesn't support PCHs. BUG=649899 Committed: https://crrev.com/52de7c17a1f9e4b3a2ed57d41afd131c0f4f8e69 Cr-Commit-Position: refs/heads/master@{#424669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
timn
Previous attempt: https://codereview.chromium.org/2394163004/
4 years, 2 months ago (2016-10-11 16:31:03 UTC) #2
brettw
lgtm
4 years, 2 months ago (2016-10-11 23:38:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410253002/1
4 years, 2 months ago (2016-10-12 04:30:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 04:41:03 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 04:42:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52de7c17a1f9e4b3a2ed57d41afd131c0f4f8e69
Cr-Commit-Position: refs/heads/master@{#424669}

Powered by Google App Engine
This is Rietveld 408576698