tools/gn/ninja_binary_target_writer.cc - Issue 2410253002: GN: Fix flags writing for targets with unsupported PCHs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 2410253002: GN: Fix flags writing for targets with unsupported PCHs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index da46149efa6b162180238c97d7414b8fdb06f9b5..9772b85a1eb01d03ad3d2df35caae72f7914b8e9 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -480,6 +480,9 @@ void NinjaBinaryTargetWriter::WriteOneFlag(

pch_file.erase(pch_file.length() - 4);

out_ << " -include " << pch_file;

}

+ } else {

+ RecursiveTargetConfigStringsToStream(target_, getter,

+ flag_escape_options, out_);

}

} else {

RecursiveTargetConfigStringsToStream(target_, getter,

« no previous file with comments | « no previous file | no next file » | no next file with comments »