Enable remoting_me2me_host_archive in official build

Enable remoting_me2me_host_archive in official build

BUG=623007
Committed: https://crrev.com/ab5f1ccc92f54412590b26a5537cbbc399221034
Cr-Commit-Position: refs/heads/master@{#425199}

[Hzj_jie, 2016-10-12 02:16:09]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 02:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2016-10-12 02:17:03]

Description was changed from

==========
Enable remoting_me2me_host_archive

BUG=623007
==========

to

==========
Enable remoting_me2me_host_archive in official build

BUG=623007
==========

[Hzj_jie, 2016-10-12 02:17:03]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org, mmoss@chromium.org

[commit-bot: I haz the power, 2016-10-12 02:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 02:27:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Michael Moss, 2016-10-12 03:15:26]

lgtm

[Hzj_jie, 2016-10-12 04:23:50]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-10-12 04:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 04:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 04:31:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Michael Moss, 2016-10-12 16:49:17]

On 2016/10/12 04:31:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like you need another reviewer for this:

  Missing LGTM from an OWNER for these files:
      BUILD.gn

[Hzj_jie, 2016-10-12 18:19:45]

On 2016/10/12 16:49:17, Michael Moss wrote:
> On 2016/10/12 04:31:02, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Looks like you need another reviewer for this:
> 
>   Missing LGTM from an OWNER for these files:
>       BUILD.gn

Oh, I thought you were the owner. No matter, let me find the right person to
review it.

[Hzj_jie, 2016-10-12 18:26:00]

zijiehe@chromium.org changed reviewers:
+ dpranke@chromium.org

[Hzj_jie, 2016-10-12 18:26:21]

Hi, Dirk, I need your approval to submit this change.

[Dirk Pranke, 2016-10-12 18:54:50]

https://codereview.chromium.org/2410163003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2410163003/diff/1/BUILD.gn#newcode130
BUILD.gn:130: deps += [ "//remoting/host:remoting_me2me_host_archive" ]
Should :remoting_host_installation just depend on :remoting_me2me_host_archive
on non-win-x86 platforms? It's kinda weird that we have two different targets
here.

[Hzj_jie, 2016-10-12 18:56:57]

On 2016/10/12 18:54:50, Dirk Pranke wrote:
> https://codereview.chromium.org/2410163003/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2410163003/diff/1/BUILD.gn#newcode130
> BUILD.gn:130: deps += [ "//remoting/host:remoting_me2me_host_archive" ]
> Should :remoting_host_installation just depend on :remoting_me2me_host_archive
> on non-win-x86 platforms? It's kinda weird that we have two different targets
> here.

Yes, that's also workable. Let me update the change.

[Hzj_jie, 2016-10-12 19:08:19]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 19:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:46:14]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-10-13 01:31:00]

On 2016/10/12 18:56:57, Hzj_jie wrote:
> On 2016/10/12 18:54:50, Dirk Pranke wrote:
> > https://codereview.chromium.org/2410163003/diff/1/BUILD.gn
> > File BUILD.gn (right):
> > 
> > https://codereview.chromium.org/2410163003/diff/1/BUILD.gn#newcode130
> > BUILD.gn:130: deps += [ "//remoting/host:remoting_me2me_host_archive" ]
> > Should :remoting_host_installation just depend on
:remoting_me2me_host_archive
> > on non-win-x86 platforms? It's kinda weird that we have two different
targets
> > here.
> 
> Yes, that's also workable. Let me update the change.

Dirk, do you have other comments?

[Dirk Pranke, 2016-10-13 01:38:18]

lgtm. 

Sorry, I didn't realize you had posted another version of the patch :(.

[Hzj_jie, 2016-10-13 19:09:31]

On 2016/10/13 01:38:18, Dirk Pranke wrote:
> lgtm. 
> 
> Sorry, I didn't realize you had posted another version of the patch :(.

No problem, thank you :)

[Hzj_jie, 2016-10-13 19:09:35]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-10-13 19:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoss@chromium.org
Link to the patchset: https://codereview.chromium.org/2410163003/#ps20001
(title: "remoting_host_installation always depends on
remoting_me2me_host_archive")

[commit-bot: I haz the power, 2016-10-13 19:09:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:22:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hzj_jie, 2016-10-13 21:34:29]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-10-13 21:37:53]

lgtm

https://codereview.chromium.org/2410163003/diff/40001/remoting/host/installer...
File remoting/host/installer/win/BUILD.gn (right):

https://codereview.chromium.org/2410163003/diff/40001/remoting/host/installer...
remoting/host/installer/win/BUILD.gn:143: # We still want to build host archive
on unsupported platforms.
I'd update 'platforms' here since this applies to 32-bit Windows build which
don't have chrome branding.

[Hzj_jie, 2016-10-13 21:41:26]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:42:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:38:00]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-10-13 22:51:14]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-10-13 22:51:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mmoss@chromium.org, joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2410163003/#ps60001
(title: "Update comments")

[Hzj_jie, 2016-10-13 22:51:18]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:51:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2016-10-13 22:51:57]

https://codereview.chromium.org/2410163003/diff/40001/remoting/host/installer...
File remoting/host/installer/win/BUILD.gn (right):

https://codereview.chromium.org/2410163003/diff/40001/remoting/host/installer...
remoting/host/installer/win/BUILD.gn:143: # We still want to build host archive
on unsupported platforms.
On 2016/10/13 21:37:53, joedow wrote:
> I'd update 'platforms' here since this applies to 32-bit Windows build which
> don't have chrome branding.

Done.

[commit-bot: I haz the power, 2016-10-13 22:57:40]

Description was changed from

==========
Enable remoting_me2me_host_archive in official build

BUG=623007
==========

to

==========
Enable remoting_me2me_host_archive in official build

BUG=623007
==========

[commit-bot: I haz the power, 2016-10-13 22:57:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-13 22:59:58]

Description was changed from

==========
Enable remoting_me2me_host_archive in official build

BUG=623007
==========

to

==========
Enable remoting_me2me_host_archive in official build

BUG=623007

Committed: https://crrev.com/ab5f1ccc92f54412590b26a5537cbbc399221034
Cr-Commit-Position: refs/heads/master@{#425199}
==========

[commit-bot: I haz the power, 2016-10-13 22:59:59]

Patchset 4 (id:??) landed as
https://crrev.com/ab5f1ccc92f54412590b26a5537cbbc399221034
Cr-Commit-Position: refs/heads/master@{#425199}