Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2410153006: [NTP Client][Reland]Use the separate button style for the NoArticles status (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[NTP Client][Reland]Use the separate button style for the NoArticles status Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG=649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} > Revert Data: > Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c > Cr-Commit-Position: refs/heads/master@{#423573} BUG=649670 Review-Url: https://codereview.chromium.org/2401643004 Cr-Commit-Position: refs/heads/master@{#423863} (cherry picked from commit 76d61d3752f37395ffcd259925ef6ded78f3d014) Committed: https://chromium.googlesource.com/chromium/src/+/a30d7b694c5efeb957f41430803a330b629100fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -301 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 4 chunks +10 lines, -23 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 1 chunk +9 lines, -94 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java View 4 chunks +68 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 6 chunks +17 lines, -37 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 23 chunks +56 lines, -100 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 4 chunks +18 lines, -30 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 2 months ago (2016-10-12 16:32:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a30d7b694c5efeb957f41430803a330b629100fc.

Powered by Google App Engine
This is Rietveld 408576698