Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2401643004: 📰 [Reland] Use the separate button style for the NoArticles status (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, Theresa
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client][Reland]Use the separate button style for the NoArticles status Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG=649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} > Revert Data: > Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c > Cr-Commit-Position: refs/heads/master@{#423573} BUG=649670 Committed: https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014 Cr-Commit-Position: refs/heads/master@{#423863}

Patch Set 1 #

Patch Set 2 : fix merge conflict #

Patch Set 3 : rebase 😠 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -301 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 1 4 chunks +10 lines, -23 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 1 1 chunk +9 lines, -94 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java View 1 4 chunks +68 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 1 6 chunks +17 lines, -37 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 1 2 23 chunks +56 lines, -100 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 1 4 chunks +18 lines, -30 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets_strings.grdp View 1 1 chunk +1 line, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
dgn
Created Reland of 📰 Use the separate button style for the NoArticles status
4 years, 2 months ago (2016-10-07 09:43:11 UTC) #1
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-07 13:49:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401643004/240001
4 years, 2 months ago (2016-10-07 14:48:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276398)
4 years, 2 months ago (2016-10-07 14:53:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401643004/260001
4 years, 2 months ago (2016-10-07 15:01:59 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:260001)
4 years, 2 months ago (2016-10-07 15:33:28 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:34:55 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014
Cr-Commit-Position: refs/heads/master@{#423863}

Powered by Google App Engine
This is Rietveld 408576698