Add a console messsage for HTTP-bad

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index e6cc266c85a03406dd0705897fd5cea1f6154b3b..acc552f6dd6e869053ac0c7db5a6fd67facc07f3 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1428,8 +1428,13 @@ void Browser::VisibleSSLStateChanged(const WebContents* source) {
   // When the current tab's SSL state changes, we need to update the URL
   // bar to reflect the new state.
   DCHECK(source);
-  if (tab_strip_model_->GetActiveWebContents() == source)
+  WebContents* active_contents = tab_strip_model_->GetActiveWebContents();
+  if (active_contents == source) {

[sky, 2016/10/14 22:21:47]

Why do you only care about the active webcontents? What happens if a navigation
is started in the background that matches your criteria and then the user
switches to the webcontents. Shouldn't they see the message?

[estark, 2016/10/14 23:50:01]

Done, but there's an unfortunate side effect of this that I have to non-const
|source|. I think that's okay, though, because content interfaces are explicitly
not supposed to have const identifiers
(https://dev.chromium.org/developers/content-module/content-api).

[sky, 2016/10/17 15:41:48]

Ick. I think it better to change the function to not take a const (line 1431
effectively gets around the const too).

[estark, 2016/10/17 16:11:13]

Why? This API explicitly goes against the content API design guidelines, why not
change it to match?

(I don't think line 1431 has anything to do with getting around the const; it
just serves to avoid unnecessary toolbar updates. In fact AFAICT
GetActiveWebContents() ends up flowing to a const parameter in
LocationBarView::Update().)

[estark, 2016/10/17 16:14:08]

Actually re-reading your comment I'm not sure I understood what you're
suggesting: what do you mean by "change the function to not take a const"? (what
function?)

     UpdateToolbar(false);
+    ChromeSecurityStateModelClient* security_model =
+        ChromeSecurityStateModelClient::FromWebContents(active_contents);
+    security_model->VisibleSSLStateChanged();
+  }
 }
 
 void Browser::AddNewContents(WebContents* source,