Add a console messsage for HTTP-bad

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 1410 matching lines @@
     command_controller_->TabStateChanged();
 
   if (hosted_app_controller_)
     hosted_app_controller_->UpdateLocationBarVisibility(true);
 }
 
 void Browser::VisibleSSLStateChanged(const WebContents* source) {
   // When the current tab's SSL state changes, we need to update the URL
   // bar to reflect the new state.
   DCHECK(source);
-  if (tab_strip_model_->GetActiveWebContents() == source)
+  WebContents* active_contents = tab_strip_model_->GetActiveWebContents();
+  if (active_contents == source) {

[sky, 2016/10/14 22:21:47]

Why do you only care about the active webcontents? What happens if a navigation
is started in the background that matches your criteria and then the user
switches to the webcontents. Shouldn't they see the message?

[estark, 2016/10/14 23:50:01]

Done, but there's an unfortunate side effect of this that I have to non-const
|source|. I think that's okay, though, because content interfaces are explicitly
not supposed to have const identifiers
(https://dev.chromium.org/developers/content-module/content-api).

[sky, 2016/10/17 15:41:48]

Ick. I think it better to change the function to not take a const (line 1431
effectively gets around the const too).

[estark, 2016/10/17 16:11:13]

Why? This API explicitly goes against the content API design guidelines, why not
change it to match?

(I don't think line 1431 has anything to do with getting around the const; it
just serves to avoid unnecessary toolbar updates. In fact AFAICT
GetActiveWebContents() ends up flowing to a const parameter in
LocationBarView::Update().)

[estark, 2016/10/17 16:14:08]

Actually re-reading your comment I'm not sure I understood what you're
suggesting: what do you mean by "change the function to not take a const"? (what
function?)

     UpdateToolbar(false);
+    ChromeSecurityStateModelClient* security_model =
+        ChromeSecurityStateModelClient::FromWebContents(active_contents);
+    security_model->VisibleSSLStateChanged();
+  }
 }
 
 void Browser::AddNewContents(WebContents* source,
                              WebContents* new_contents,
                              WindowOpenDisposition disposition,
                              const gfx::Rect& initial_rect,
                              bool user_gesture,
                              bool* was_blocked) {
   chrome::AddWebContents(this, source, new_contents, disposition, initial_rect,
                          user_gesture, was_blocked);
@@ skipping 1127 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         ui::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }