Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3035)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 2409923002: cc: Rename SwapBuffers on CompositorFrameSink to SubmitCompositorFrame (Closed)
Patch Set: swap-to-submit: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index ccbd9e7393ee42373e8fea65dfebf6b39727e481..b947de444eba81b07ac536c37c2308da2526cf64 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -99,7 +99,7 @@ class LayerTreeHostImplClient {
public:
virtual void DidLoseCompositorFrameSinkOnImplThread() = 0;
virtual void SetBeginFrameSource(BeginFrameSource* source) = 0;
- virtual void DidSwapBuffersCompleteOnImplThread() = 0;
+ virtual void DidReceiveCompositorFrameAckOnImplThread() = 0;
virtual void OnCanDrawStateChanged(bool can_draw) = 0;
virtual void NotifyReadyToActivate() = 0;
virtual void NotifyReadyToDraw() = 0;
@@ -302,6 +302,7 @@ class CC_EXPORT LayerTreeHostImpl
// DidDrawAllLayers must also be called, regardless of whether DrawLayers is
// called between the two.
virtual DrawResult PrepareToDraw(FrameData* frame);
+ // TODO(danakj): This isn't "drawing" it's "generating a frame".
sunnyps 2016/10/11 18:32:48 aside: I think it's OK for this to be called drawi
danakj 2016/10/13 23:50:22 Done.
virtual bool DrawLayers(FrameData* frame);
// Must be called if and only if PrepareToDraw was called.
void DidDrawAllLayers(const FrameData& frame);
@@ -365,7 +366,7 @@ class CC_EXPORT LayerTreeHostImpl
const gfx::Rect& viewport_rect,
const gfx::Transform& transform) override;
void DidLoseCompositorFrameSink() override;
- void DidSwapBuffersComplete() override;
+ void DidReceiveCompositorFrameAck() override;
void ReclaimResources(const ReturnedResourceArray& resources) override;
void SetMemoryPolicy(const ManagedMemoryPolicy& policy) override;
void SetTreeActivationCallback(const base::Closure& callback) override;

Powered by Google App Engine
This is Rietveld 408576698