Chromium Code Reviews| Index: cc/scheduler/scheduler_state_machine.h |
| diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h |
| index 16ee4d6b4347993e8af86e944202422f71389e46..3399d47f5524b3ed0868bf1e802eda839accc79c 100644 |
| --- a/cc/scheduler/scheduler_state_machine.h |
| +++ b/cc/scheduler/scheduler_state_machine.h |
| @@ -116,9 +116,9 @@ class CC_EXPORT SchedulerStateMachine { |
| ACTION_SEND_BEGIN_MAIN_FRAME, |
| ACTION_COMMIT, |
| ACTION_ACTIVATE_SYNC_TREE, |
| - ACTION_DRAW_AND_SWAP_IF_POSSIBLE, |
| - ACTION_DRAW_AND_SWAP_FORCED, |
| - ACTION_DRAW_AND_SWAP_ABORT, |
| + ACTION_SUBMIT_COMPOSITOR_FRAME_IF_POSSIBLE, |
| + ACTION_SUBMIT_COMPOSITOR_FRAME_FORCED, |
| + ACTION_SUBMIT_COMPOSITOR_FRAME_ABORT, |
| ACTION_BEGIN_COMPOSITOR_FRAME_SINK_CREATION, |
| ACTION_PREPARE_TILES, |
| ACTION_INVALIDATE_COMPOSITOR_FRAME_SINK, |
| @@ -139,7 +139,7 @@ class CC_EXPORT SchedulerStateMachine { |
| void DidDraw(DrawResult draw_result); |
| - void AbortDrawAndSwap(); |
| + void AbortSubmitCompositorFrame(); |
| // Indicates whether the impl thread needs a BeginImplFrame callback in order |
| // to make progress. |
| @@ -168,7 +168,7 @@ class CC_EXPORT SchedulerStateMachine { |
| return main_thread_missed_last_deadline_; |
| } |
| - bool SwapThrottled() const; |
| + bool SubmitThrottled() const; |
|
enne (OOO)
2016/10/11 17:26:00
bikeshedding: IsSubmitThrottled?
danakj
2016/10/13 23:50:22
Went to IsDrawThrottled.
|
| // Indicates whether the LayerTreeHostImpl is visible. |
| void SetVisible(bool visible); |
| @@ -191,16 +191,12 @@ class CC_EXPORT SchedulerStateMachine { |
| // If the scheduler attempted to draw and swap, this provides feedback |
| // regarding whether or not the swap actually occured. We might skip the |
| // swap when there is not damage, for example. |
| - void DidSwapBuffers(); |
| - |
| - // Indicates whether a redraw is required because we are currently rendering |
| - // with a low resolution or checkerboarded tile. |
| - void SetSwapUsedIncompleteTile(bool used_incomplete_tile); |
|
sunnyps
2016/10/11 18:32:48
Can you clarify why this method was removed?
danakj
2016/10/13 23:50:22
The method doesn't exist only the definition does.
|
| + void DidSubmitCompositorFrame(); |
| // Notification from the CompositorFrameSink that a swap has been consumed. |
| - void DidSwapBuffersComplete(); |
| + void DidReceiveCompositorFrameAck(); |
| - int pending_swaps() const { return pending_swaps_; } |
| + int pending_submit_frames() const { return pending_submit_frames_; } |
| // Indicates whether to prioritize impl thread latency (i.e., animation |
| // smoothness) over new content activation. |
| @@ -305,7 +301,7 @@ class CC_EXPORT SchedulerStateMachine { |
| // These are used for tracing only. |
| int commit_count_; |
| int current_frame_number_; |
| - int last_frame_number_swap_performed_; |
| + int last_frame_number_submit_performed_; |
| int last_frame_number_draw_performed_; |
| int last_frame_number_begin_main_frame_sent_; |
| int last_frame_number_invalidate_compositor_frame_sink_performed_; |
| @@ -322,9 +318,9 @@ class CC_EXPORT SchedulerStateMachine { |
| int prepare_tiles_funnel_; |
| int consecutive_checkerboard_animations_; |
| - int max_pending_swaps_; |
| - int pending_swaps_; |
| - int swaps_with_current_compositor_frame_sink_; |
| + int max_pending_submit_frames_; |
| + int pending_submit_frames_; |
| + int submit_frames_with_current_compositor_frame_sink_; |
| bool needs_redraw_; |
| bool needs_prepare_tiles_; |
| bool needs_begin_main_frame_; |
| @@ -347,7 +343,7 @@ class CC_EXPORT SchedulerStateMachine { |
| bool last_commit_had_no_updates_; |
| bool wait_for_ready_to_draw_; |
| bool did_draw_in_last_frame_; |
| - bool did_swap_in_last_frame_; |
| + bool did_submit_in_last_frame_; |
| private: |
| DISALLOW_COPY_AND_ASSIGN(SchedulerStateMachine); |