Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3445)

Unified Diff: cc/scheduler/scheduler.h

Issue 2409923002: cc: Rename SwapBuffers on CompositorFrameSink to SubmitCompositorFrame (Closed)
Patch Set: swap-to-submit: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index 235a4f8e4e2974d816eea81d1d294cdae1968cfc..85af81be0afeabc822c02c3b4c65affed17052f3 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -38,8 +38,8 @@ class SchedulerClient {
virtual void WillBeginImplFrame(const BeginFrameArgs& args) = 0;
virtual void ScheduledActionSendBeginMainFrame(
const BeginFrameArgs& args) = 0;
- virtual DrawResult ScheduledActionDrawAndSwapIfPossible() = 0;
- virtual DrawResult ScheduledActionDrawAndSwapForced() = 0;
+ virtual DrawResult ScheduledActionSubmitCompositorFrameIfPossible() = 0;
+ virtual DrawResult ScheduledActionSubmitCompositorFrameForced() = 0;
sunnyps 2016/10/11 18:32:48 I'd prefer these to be called ScheduledActionDraw
danakj 2016/10/13 23:50:22 Done.
virtual void ScheduledActionCommit() = 0;
virtual void ScheduledActionActivateSyncTree() = 0;
virtual void ScheduledActionBeginCompositorFrameSinkCreation() = 0;
@@ -89,8 +89,8 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void SetNeedsPrepareTiles();
- void DidSwapBuffers();
- void DidSwapBuffersComplete();
+ void DidSubmitCompositorFrame();
+ void DidReceiveCompositorFrameAck();
void SetTreePrioritiesAndScrollState(TreePriority tree_priority,
ScrollHandlerState scroll_handler_state);
@@ -174,8 +174,8 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void ScheduleBeginImplFrameDeadlineIfNeeded();
void BeginImplFrameNotExpectedSoon();
void SetupNextBeginFrameIfNeeded();
- void DrawAndSwapIfPossible();
- void DrawAndSwapForced();
+ void SubmitCompositorFrameIfPossible();
+ void SubmitCompositorFrameForced();
void ProcessScheduledActions();
void UpdateCompositorTimingHistoryRecordingEnabled();
bool ShouldRecoverMainLatency(const BeginFrameArgs& args,

Powered by Google App Engine
This is Rietveld 408576698