Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp - Issue 24096029: Moved the majority of WebGL functionality into WebGLRenderingContextBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

Issue 24096029: Moved the majority of WebGL functionality into WebGLRenderingContextBase (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

index eb863d76fb16fc310f59f302f4147b4f3bb18380..188bfa10ec520460090ad0b0b8fe1c509b8485b0 100644

--- a/Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp

@@ -54,7 +54,7 @@ void V8HTMLCanvasElement::getContextMethodCustom(const v8::FunctionCallbackInfo<

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, contextIdResource, args[0]);

String contextId = contextIdResource;

RefPtr<CanvasContextAttributes> attributes;

- if (contextId == "webgl" || contextId == "experimental-webgl" || contextId == "webkit-3d") {

+ if (contextId == "webgl2" || contextId == "webgl" || contextId == "experimental-webgl" || contextId == "webkit-3d") {

RefPtr<WebGLContextAttributes> webGLAttributes = WebGLContextAttributes::create();

if (args.Length() > 1 && args[1]->IsObject()) {

v8::Handle<v8::Object> jsAttributes = args[1]->ToObject();