[regexp] Port remaining JS functions in regexp.js

[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339
Committed: https://crrev.com/a10b4712c636b85715df812117d51440282cf67c
Cr-Commit-Position: refs/heads/master@{#40277}

[jgruber, 2016-10-10 12:37:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 12:38:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 12:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 12:39:49]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/14183)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26010)

[jgruber, 2016-10-13 07:47:25]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-13 07:49:54]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2016-10-13 08:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 08:10:06]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/14480)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2016-10-13 08:53:47]

Description was changed from

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function); InternalReplace is in TurboFan because it calls
into runtime.

Except for LastMatchInfo, regexp.js is now completely empty.

BUG=v8:5339
==========

to

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function); InternalReplace is in TurboFan because it calls
into runtime.

Except for LastMatchInfo, regexp.js is now completely empty.

BUG=v8:5339
==========

[jgruber, 2016-10-13 08:53:48]

jgruber@chromium.org changed reviewers:
- yangguo@chromium.org

[jgruber, 2016-10-13 10:34:56]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 10:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 10:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 10:46:57]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2016-10-13 11:51:10]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-10-13 11:51:11]

lgtm

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:1683: compiler::Node*
GetInternalMatchInfo(CodeStubAssembler* a,
This allocates a new array on every invocation. I guess for i18n this is fine,
but the inspector also wants to use these two functions. Maybe we can reuse this
by putting it on the native context?

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins.h...
src/builtins/builtins.h:580: TFJ(RegExpInternalReplace, 4)                      
                        \
I would have implemented internal match and replace in C++ first, since we only
use that in i18n? But I guess since you already have that in TF we can keep it
this way.

[jgruber, 2016-10-13 12:02:38]

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:1683: compiler::Node*
GetInternalMatchInfo(CodeStubAssembler* a,
On 2016/10/13 11:51:11, Yang wrote:
> This allocates a new array on every invocation. I guess for i18n this is fine,
> but the inspector also wants to use these two functions. Maybe we can reuse
this
> by putting it on the native context?

Sure. I'll take care of it once the FixedArray conversion for match infos is
done.

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2409513003/diff/20001/src/builtins/builtins.h...
src/builtins/builtins.h:580: TFJ(RegExpInternalReplace, 4)                      
                        \
On 2016/10/13 11:51:11, Yang wrote:
> I would have implemented internal match and replace in C++ first, since we
only
> use that in i18n? But I guess since you already have that in TF we can keep it
> this way.

It's explained in the commit message why these two are TurboFan stubs. Plus,
both of them are pretty trivial so we don't lose much on readability.

[jgruber, 2016-10-13 12:03:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 12:03:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 12:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 12:31:34]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-10-13 12:55:37]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 12:55:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-13 13:21:59]

Moved all except InternalMatch to runtime, PTAL

[jgruber, 2016-10-13 13:34:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 13:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-10-13 13:55:21]

lgtm

[commit-bot: I haz the power, 2016-10-13 14:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:10:21]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10748)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[jgruber, 2016-10-13 14:13:33]

Description was changed from

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function); InternalReplace is in TurboFan because it calls
into runtime.

Except for LastMatchInfo, regexp.js is now completely empty.

BUG=v8:5339
==========

to

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339
==========

[jgruber, 2016-10-13 14:17:12]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-10-13 14:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2409513003/#ps120001
(title: "Rebaseline bytecode expectations")

[commit-bot: I haz the power, 2016-10-13 14:17:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:02:52]

Description was changed from

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339
==========

to

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339
==========

[commit-bot: I haz the power, 2016-10-13 15:02:53]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-13 15:03:32]

Description was changed from

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339
==========

to

==========
[regexp] Port remaining JS functions in regexp.js

This ports RegExpInitialize, IsRegExp, InternalMatch and InternalReplace to C++
/ TurboFan. InternalMatch is in TurboFan because it calls RegExpExecStub and
needs to construct a RegExpResult (which are, respectively, a PlatformStub and
a CodeStubAssembler function).

Except for LastMatchInfo (and GetSubstitution, which could be moved to string.js
anytime), regexp.js is now completely empty.

BUG=v8:5339

Committed: https://crrev.com/a10b4712c636b85715df812117d51440282cf67c
Cr-Commit-Position: refs/heads/master@{#40277}
==========

[commit-bot: I haz the power, 2016-10-13 15:03:33]

Patchset 7 (id:??) landed as
https://crrev.com/a10b4712c636b85715df812117d51440282cf67c
Cr-Commit-Position: refs/heads/master@{#40277}